Merge lp:~vicamo/telephony-service/send-stop-tone-at-last into lp:telephony-service

[You-Sheng Yang]

Class ToneGenerator creates a oneshot timer to keep track of when to send a StopTone req after successfully sending a StartEventTone one. However, when playDTMFTone() is called the second time within the timeout interval (0.2s), it's currently completely ignored and no tone will ever be generated. As a result, when someone presses dialpad buttons very quickly, some of them sound missed because not each of them is accompanied by a DTMF tone.

This patch changes the behavior as: for each playDTMFTone() call, send a StartEventTone and (re)start the timer. This way, every dialpad press causes a DTMF tone being generated and the longest duration of each tone is still 0.2 second.

Class ToneGenerator creates a oneshot timer to keep track of when to send a StopTone req after successfully sending a StartEventTone one. However, when playDTMFTone() is called the second time within the timeout interval (0.2s), it's currently completely ignored and no tone will ever be generated. As a result, when someone presses dialpad buttons very quickly, some of them sound missed because not each of them is accompanied by a DTMF tone.

This patch changes the behavior as: for each playDTMFTone() call, send a StartEventTone and (re)start the timer. This way, every dialpad press causes a DTMF tone being generated and the longest duration of each tone is still 0.2 second.

[lp:~vicamo/telephony-service/send-stop-tone-at-last]

1010. By Gustavo Pichorim Boiko on 2015-02-03

Move the serial to be a property on account entry, and make sure it is read even
when the account is not connected.
Approved by: PS Jenkins bot

1011. By CI Train Bot Account on 2015-02-03

Releasing 0.1+15.04.20150203-0ubuntu1

1012. By Tiago Salem Herrmann on 2015-02-05

Add initial MMS group chat support. Fixes: #1415458

1013. By CI Train Bot Account on 2015-02-05

Releasing 0.1+15.04.20150205-0ubuntu1

1014. By Tiago Salem Herrmann on 2015-02-05

Avoid using ofono to get the list of modems in ofono-setup. Fixes: #1413316
Approved by: PS Jenkins bot

1015. By CI Train Bot Account on 2015-02-05

Releasing 0.1+15.04.20150205.1-0ubuntu1

1016. By Launchpad Translations on behalf of phablet-team on 2015-02-09

Launchpad automatic translations update.

1017. By Launchpad Translations on behalf of phablet-team on 2015-02-11

Launchpad automatic translations update.

1018. By Gustavo Pichorim Boiko on 2015-02-11

Ignore accounts not explicitly supported for now. Fixes: #1340758
Approved by: PS Jenkins bot

1019. By Tiago Salem Herrmann on 2015-02-11

Initialize variables to avoid randomly showing the voicemail indicator for telepathy accounts that do not support the voicemail interface.

1020. By CI Train Bot Account on 2015-02-11

Releasing 0.1+15.04.20150211-0ubuntu1

1021. By Launchpad Translations on behalf of phablet-team on 2015-02-12

Launchpad automatic translations update.

1022. By Launchpad Translations on behalf of phablet-team on 2015-02-13

Launchpad automatic translations update.

1023. By Launchpad Translations on behalf of phablet-team on 2015-02-15

Launchpad automatic translations update.

1024. By Launchpad Translations on behalf of phablet-team on 2015-02-16

Launchpad automatic translations update.

1025. By Tiago Salem Herrmann on 2015-02-17

Don't remove the call channel if hangup() does not succeed.

1026. By CI Train Bot Account on 2015-02-17

Releasing 0.1+15.04.20150217-0ubuntu1

1027. By Launchpad Translations on behalf of phablet-team on 2015-02-20

Launchpad automatic translations update.

1028. By Launchpad Translations on behalf of phablet-team on 2015-02-21

Launchpad automatic translations update.

1029. By Launchpad Translations on behalf of phablet-team on 2015-02-23

Launchpad automatic translations update.

1030. By Launchpad Translations on behalf of phablet-team on 2015-02-27

Launchpad automatic translations update.

1031. By Tiago Salem Herrmann on 2015-02-27

Check if default sim is active before sending messages. Fixes: #1423942
Approved by: Sebastien Bacher

1032. By Tiago Salem Herrmann on 2015-02-27

Do not create instance of GreeterContacts to avoid dealock with unity. Fixes: #1426399

1033. By CI Train Bot Account on 2015-02-27

Releasing 0.1+15.04.20150227-0ubuntu1

1034. By Launchpad Translations on behalf of phablet-team on 2015-02-28

Launchpad automatic translations update.

1035. By Launchpad Translations on behalf of phablet-team on 2015-03-02

Launchpad automatic translations update.

1036. By Launchpad Translations on behalf of phablet-team on 2015-03-04

Launchpad automatic translations update.

1037. By Launchpad Translations on behalf of phablet-team on 2015-03-08

Launchpad automatic translations update.

1038. By Launchpad Translations on behalf of phablet-team on 2015-03-09

Launchpad automatic translations update.

1039. By Launchpad Translations on behalf of phablet-team on 2015-03-10

Launchpad automatic translations update.

1040. By Launchpad Translations on behalf of phablet-team on 2015-03-14

Launchpad automatic translations update.

1041. By Launchpad Translations on behalf of phablet-team on 2015-03-19

Launchpad automatic translations update.

1042. By Launchpad Translations on behalf of phablet-team on 2015-03-23

Launchpad automatic translations update.

1043. By You-Sheng Yang on 2015-03-24

Send StopTone at the last dialpad press

Class ToneGenerator creates a oneshot timer to keep track of when to
send a StopTone req after successfully sending a StartEventTone one.
However, when playDTMFTone() is called the second time within the
timeout interval (0.2s), it's currently completely ignored and no
tone will ever be generated. As a result, when someone presses
dialpad buttons very quickly, some of them sound missed because not
each of them is accompanied by a DTMF tone.

This patch changes the behavior as: for each playDTMFTone() call,
send a StartEventTone and (re)start the timer. This way, every
dialpad press causes a DTMF tone being generated and the longest
duration of each tone is still 0.2 second.

[You-Sheng Yang (vicamo)]

Any comments?

[Gustavo Pichorim Boiko (boiko)]

Code looks good and works as expected!

Sorry for the long time to review that.

review: Approve

=== modified file 'libtelephonyservice/tonegenerator.cpp'
--- libtelephonyservice/tonegenerator.cpp	2014-10-16 17:04:19 +0000
+++ libtelephonyservice/tonegenerator.cpp	2015-03-24 08:39:49 +0000
@@ -69,20 +69,17 @@
 
 void ToneGenerator::playDTMFTone(uint key)
 {
-    if (!mDTMFPlaybackTimer) {
-        mDTMFPlaybackTimer = new QTimer(this);
-        mDTMFPlaybackTimer->setSingleShot(true);
-        connect(mDTMFPlaybackTimer, SIGNAL(timeout()), this, SLOT(stopDTMFTone()));
-    }
-    if (mDTMFPlaybackTimer->isActive()) {
-        qDebug() << "Already playing a tone, ignore.";
-        return;
-    }
     if (key > 11) {
         qDebug() << "Invalid DTMF tone, ignore.";
         return;
     }
+
     if (startEventTone(key)) {
+        if (!mDTMFPlaybackTimer) {
+            mDTMFPlaybackTimer = new QTimer(this);
+            mDTMFPlaybackTimer->setSingleShot(true);
+            connect(mDTMFPlaybackTimer, SIGNAL(timeout()), this, SLOT(stopDTMFTone()));
+        }
         mDTMFPlaybackTimer->start(DTMF_LOCAL_PLAYBACK_DURATION);
     }
 }
@@ -103,7 +100,6 @@
     if (mDTMFPlaybackTimer) {
         mDTMFPlaybackTimer->stop();
     }
-
 }
 
 void ToneGenerator::playWaitingTone()