lp:~vicamo/telephony-service/send-stop-tone-at-last
Created by
You-Sheng Yang
and last modified
- Get this branch:
- bzr branch lp:~vicamo/telephony-service/send-stop-tone-at-last
Only
You-Sheng Yang
can upload to this branch. If you are
You-Sheng Yang
please log in for upload directions.
Branch merges
Propose for merging
No branches
dependent on this one.
- Gustavo Pichorim Boiko (community): Approve
-
Diff: 38 lines (+6/-10)1 file modifiedlibtelephonyservice/tonegenerator.cpp (+6/-10)
Related source package recipes
Related bugs
Related blueprints
Branch information
Recent revisions
- 1043. By You-Sheng Yang
-
Send StopTone at the last dialpad press
Class ToneGenerator creates a oneshot timer to keep track of when to
send a StopTone req after successfully sending a StartEventTone one.
However, when playDTMFTone() is called the second time within the
timeout interval (0.2s), it's currently completely ignored and no
tone will ever be generated. As a result, when someone presses
dialpad buttons very quickly, some of them sound missed because not
each of them is accompanied by a DTMF tone.This patch changes the behavior as: for each playDTMFTone() call,
send a StartEventTone and (re)start the timer. This way, every
dialpad press causes a DTMF tone being generated and the longest
duration of each tone is still 0.2 second.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:telephony-service
