libhybris

Code review comment for ~vicamo/libhybris/+git/libhybris:for-libhybris-maintainers/bug-1619107/media-service-for-32-bit-codecs

  1. Git
  2. lp:~vicamo/libhybris/+git/libhybris
  3. for-libhybris-maintainers/bug-1619107/media-service-for-32-bit-codecs
  4. Merge into master
Revision history for this message
You-Sheng Yang (vicamo) wrote :

So far codec listing works internally, but not for libhybris. The Bp part of a MediaCodec is returned as a shared pointer, and while we have:

  return MediaCodecList::getInstance()->getCodecInfo(index)->getCodecName();

The returned string pointer will be invalidated right after the return statement because nobody holds a reference to that MediaCodec shared pointer, and it desctructs itself right away.

Reply

« Back to merge proposal