Merge ~vicamo/android-headers/+git/android-headers:for-launchpad/align-arm64-struct-size into android-headers:master

Proposed by You-Sheng Yang
Status: Merged
Merge reported by: Simon Fels
Merged at revision: not available
Proposed branch: ~vicamo/android-headers/+git/android-headers:for-launchpad/align-arm64-struct-size
Merge into: android-headers:master
Diff against target: 29 lines (+8/-0)
1 file modified
19/hardware/hardware.h (+8/-0)
Reviewer Review Type Date Requested Status
Simon Fels Approve
Review via email: mp+302644@code.launchpad.net

Description of the change

android-19: hardware: align struct size on arm64

All other(21,22,23) versions have addressed this issue.

To post a comment you must log in.
Revision history for this message
Simon Fels (morphis) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/19/hardware/hardware.h b/19/hardware/hardware.h
index 416ae39..74f57aa 100644
--- a/19/hardware/hardware.h
+++ b/19/hardware/hardware.h
@@ -144,8 +144,12 @@ typedef struct hw_module_t {
144 /** module's dso */144 /** module's dso */
145 void* dso;145 void* dso;
146146
147#ifdef __LP64__
148 uint64_t reserved[32-7];
149#else
147 /** padding to 128 bytes, reserved for future use */150 /** padding to 128 bytes, reserved for future use */
148 uint32_t reserved[32-7];151 uint32_t reserved[32-7];
152#endif
149153
150} hw_module_t;154} hw_module_t;
151155
@@ -186,7 +190,11 @@ typedef struct hw_device_t {
186 struct hw_module_t* module;190 struct hw_module_t* module;
187191
188 /** padding reserved for future use */192 /** padding reserved for future use */
193#ifdef __LP64__
194 uint64_t reserved[12];
195#else
189 uint32_t reserved[12];196 uint32_t reserved[12];
197#endif
190198
191 /** Close this device */199 /** Close this device */
192 int (*close)(struct hw_device_t* device);200 int (*close)(struct hw_device_t* device);

Subscribers

People subscribed via source and target branches