Code review comment for lp:~vexo/bzr-webdav/bzr-webdav

Revision history for this message
Vincent Ladeuil (vila) wrote :

This should have landed now, just a few comments for the record:

I've dive in the code again and was able to further clean up various areas:

77 if code not in (200, 201, 204):
78 - self._raise_curl_http_error(abspath, response,
79 + self._raise_http_error(abspath, response,
80 'expected 200, 201 or 204.')

This was really dead code so I completely removed it (_perform() itself will raise the proper error so the _raise_curl_http_error couldn't be reached anyway).

I've added a test_delete_replies_202 with associated infrastructure to bypass the server code and just exercise the client one.

I removed some other dead code and useless imports.

Once again, thanks for your work.

« Back to merge proposal