Merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/sgtileitem-keep-data into lp:ubuntu-docviewer-app
Proposed by
Stefano Verzegnassi
Status: | Merged |
---|---|
Approved by: | Stefano Verzegnassi |
Approved revision: | 279 |
Merged at revision: | 282 |
Proposed branch: | lp:~verzegnassi-stefano/ubuntu-docviewer-app/sgtileitem-keep-data |
Merge into: | lp:ubuntu-docviewer-app |
Diff against target: |
13 lines (+0/-3) 1 file modified
src/plugin/libreofficetoolkit-qml-plugin/sgtileitem.cpp (+0/-3) |
To merge this branch: | bzr merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/sgtileitem-keep-data |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Roman Shchekin | Approve | ||
Jenkins Bot | continuous-integration | Approve | |
Review via email: mp+283958@code.launchpad.net |
Commit message
SGTileItem: keep QImage data so that QSG don't fail on repainting
Description of the change
Sometimes we get some blank tile when rendering a document.
This happens only when a document is loaded for the first time: the tile gets painted with the proper texture, then it becomes blank.
I don't know much how the Qt SceneGraph works behind the scenes, but it seems that it deletes the old node of a tile when an update() is requested.
Since m_data is null when that happens, SGTileItem does not repaint the node texture as expected.
To post a comment you must log in.
PASSED: Continuous integration, rev:279 /core-apps- jenkins. ubuntu. com/job/ run-ap- tests-ci/ 187/ /core-apps- jenkins. ubuntu. com/job/ generic- update- mp/471/ console
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild: /core-apps- jenkins. ubuntu. com/job/ run-ap- tests-ci/ 187/rebuild
https:/