Code review comment for lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-app-init

Revision history for this message
Stefano Verzegnassi (verzegnassi-stefano) wrote :

Currently config.h needs to be configured by CMake. Both in rev.193 (which has been approved by Jenkins) and rev. 195 that does not happen.

For what I understand, the Debian package created by Jenkins tries to load "@DATA_DIR@/qml/ubuntu-docviewer-app.qml", which is not a legal path.

Don't know how it successed with tests, since they should fail.

review: Needs Fixing

« Back to merge proposal