Merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-pdfview-be-visibility into lp:ubuntu-docviewer-app

Proposed by Stefano Verzegnassi
Status: Merged
Approved by: Stefano Verzegnassi
Approved revision: 303
Merged at revision: 304
Proposed branch: lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-pdfview-be-visibility
Merge into: lp:ubuntu-docviewer-app
Diff against target: 21 lines (+4/-0)
1 file modified
src/app/qml/pdfView/PdfView.qml (+4/-0)
To merge this branch: bzr merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-pdfview-be-visibility
Reviewer Review Type Date Requested Status
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Jenkins Bot continuous-integration Approve
Review via email: mp+286193@code.launchpad.net

Commit message

[PdfView] Disable bottom edge gesture if the current document does not provide any ToC

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

Works perfectly.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/app/qml/pdfView/PdfView.qml'
--- src/app/qml/pdfView/PdfView.qml 2016-02-03 13:51:11 +0000
+++ src/app/qml/pdfView/PdfView.qml 2016-02-16 15:57:49 +0000
@@ -155,6 +155,9 @@
155 onTriggered: contentsBottomEdge.commit()155 onTriggered: contentsBottomEdge.commit()
156 }156 }
157 flickable: pdfPage.flickable157 flickable: pdfPage.flickable
158
159 visible: contentsBottomEdge.visible
160 enabled: contentsBottomEdge.enabled
158 }161 }
159162
160 contentComponent: Item {163 contentComponent: Item {
@@ -164,6 +167,7 @@
164 }167 }
165168
166 enabled: poppler.tocModel.count > 0169 enabled: poppler.tocModel.count > 0
170 visible: enabled
167171
168 onCollapseCompleted: {172 onCollapseCompleted: {
169 _realPage = contentsPage.createObject(null)173 _realPage = contentsPage.createObject(null)

Subscribers

People subscribed via source and target branches