Ubuntu One Client

Code review comment for lp:~verterok/ubuntuone-client/bad-bad-symlink

  1. bad-bad-symlink
  2. Merge into trunk
Revision history for this message
John O'Brien (jdobrien) wrote :

john@Monolith:~/canonical/ubuntuone/ubuntuone-client/bad-bad-symlink$ PYTHONPATH=. bin/ubuntuone-syncdaemon --debug
2009-08-27 11:06:25,183 - ubuntuone.SyncDaemon.VM - DEBUG - upgrading from metadata 3 (new layout)
2009-08-27 11:06:25,187 - ubuntuone.SyncDaemon - ERROR - Unexpected error
Traceback (most recent call last):
  File "bin/ubuntuone-syncdaemon", line 192, in <module>
    main(sys.argv)
  File "bin/ubuntuone-syncdaemon", line 145, in main
    shares_symlink_name='Shared With Me')
  File "/home/john/canonical/ubuntuone/ubuntuone-client/bad-bad-symlink/ubuntuone/syncdaemon/main.py", line 96, in __init__
    self.vm = volume_manager.VolumeManager(self)
  File "/home/john/canonical/ubuntuone/ubuntuone-client/bad-bad-symlink/ubuntuone/syncdaemon/volume_manager.py", line 125, in __init__
    upgrade_method(md_version)
  File "/home/john/canonical/ubuntuone/ubuntuone-client/bad-bad-symlink/ubuntuone/syncdaemon/volume_manager.py", line 563, in _upgrade_metadata_3
    share.path = share.path.replace(old_root_dir, self.m.root_dir)
AttributeError: 'NoneType' object has no attribute 'replace'
Traceback (most recent call last):
  File "bin/ubuntuone-syncdaemon", line 192, in <module>
    main(sys.argv)
  File "bin/ubuntuone-syncdaemon", line 145, in main
    shares_symlink_name='Shared With Me')
  File "/home/john/canonical/ubuntuone/ubuntuone-client/bad-bad-symlink/ubuntuone/syncdaemon/main.py", line 96, in __init__
    self.vm = volume_manager.VolumeManager(self)
  File "/home/john/canonical/ubuntuone/ubuntuone-client/bad-bad-symlink/ubuntuone/syncdaemon/volume_manager.py", line 125, in __init__
    upgrade_method(md_version)
  File "/home/john/canonical/ubuntuone/ubuntuone-client/bad-bad-symlink/ubuntuone/syncdaemon/volume_manager.py", line 563, in _upgrade_metadata_3
    share.path = share.path.replace(old_root_dir, self.m.root_dir)
AttributeError: 'NoneType' object has no attribute 'replace'

review: Needs Fixing

« Back to merge proposal