Merge ~verterok/prometheus-charm/+git/prometheus-charm:scrape_interval_and_timeout_support into prometheus-charm:master

Proposed by Guillermo Gonzalez
Status: Merged
Approved by: Alexandre Gomes
Approved revision: 2ec6fbd3172cc6cce5965f3423d2a7e802f94109
Merged at revision: 50542c12a0df6f935144522c8a58f18bb398a630
Proposed branch: ~verterok/prometheus-charm/+git/prometheus-charm:scrape_interval_and_timeout_support
Merge into: prometheus-charm:master
Diff against target: 17 lines (+6/-0)
1 file modified
templates/prometheus.yml.j2 (+6/-0)
Reviewer Review Type Date Requested Status
Alexandre Gomes Approve
Review via email: mp+345555@code.launchpad.net

Commit message

Add support for scrape_interval and scrape_timeout from the scrape relation data

Description of the change

Add support for scrape_interval and scrape_timeout from the scrape relation data

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Alexandre Gomes (alejdg) wrote :

+1

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 50542c12a0df6f935144522c8a58f18bb398a630

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/templates/prometheus.yml.j2 b/templates/prometheus.yml.j2
index a63be80..cd010f4 100644
--- a/templates/prometheus.yml.j2
+++ b/templates/prometheus.yml.j2
@@ -40,6 +40,12 @@ scrape_configs:
40{%- for scrape_job in scrape_jobs %}40{%- for scrape_job in scrape_jobs %}
41 - job_name: '{{ scrape_job.job_name }}'41 - job_name: '{{ scrape_job.job_name }}'
42 metrics_path: '{{ scrape_job.metrics_path }}'42 metrics_path: '{{ scrape_job.metrics_path }}'
43{%- if scrape_job.get('scrape_interval') %}
44 scrape_interval: {{ scrape_job['scrape_interval']}}
45{%- endif %}
46{%- if scrape_job.get('scrape_timeout') %}
47 scrape_timeout: {{ scrape_job['scrape_timeout']}}
48{%- endif %}
43{%- if scrape_job.get('scheme') %}49{%- if scrape_job.get('scheme') %}
44 scheme: {{ scrape_job['scheme']}}50 scheme: {{ scrape_job['scheme']}}
45{%- endif %}51{%- endif %}

Subscribers

People subscribed via source and target branches