Merge lp:~verterok/ols-tests/feature-handle-failing-probe into lp:ols-tests

[Guillermo Gonzalez]

Handle failing probe in Feature.available

Feature availability is evaluated on import, if the probe fails with an exception the test run is interrupted instead of marking the feature as not available

[Daniel Manrique (roadmr)]

lgtm

review: Approve

=== modified file 'olstests/features.py'
--- olstests/features.py	2016-02-08 17:54:01 +0000
+++ olstests/features.py	2023-05-01 10:10:02 +0000
@@ -32,7 +32,11 @@
         :return: True if the feature is available.
         """
         if self._available is None:
-            self._available = self._probe()
+            try:
+                self._available = self._probe()
+            except Exception:
+                # if the _probe fails, mark this as not available
+                self._available = False
         return self._available
 
     def _probe(self):

=== modified file 'olstests/tests/test_features.py'
--- olstests/tests/test_features.py	2016-02-08 17:54:01 +0000
+++ olstests/tests/test_features.py	2023-05-01 10:10:02 +0000
@@ -66,6 +66,21 @@
         feature = NamedFeature()
         self.assertEqual('NamedFeature', unicode(feature))
 
+    def test_failing_probe(self):
+
+        class FailingFeature(features.Feature):
+            def __init__(self):
+                super(FailingFeature, self).__init__()
+                self.calls = []
+
+            def _probe(self):
+                self.calls.append('_probe')
+                raise OSError('No such file')
+
+        feature = FailingFeature()
+        self.assertFalse(feature.available())
+        self.assertEqual(['_probe'], feature.calls)
+
 
 class TestUbuntuPlatformFeature(unittest.TestCase):