Code review comment for lp:~verterok/charms/trusty/mongodb/fix-data_directory-migration

Revision history for this message
Guillermo Gonzalez (verterok) wrote :

Hi Adam,

Thanks for the prompt reply.
I tried to get an amulet test for this, but I cannot find a way to test this without making a really complex test case, e.g: adding 2 more charms (storage and block-storage-provider) plus handling credentials for the cloud that's used to run tests.

Also tried to use the local prodiver (for the storage charm), but found a new bug in the mongo charm, it fails if the provider is local (just a directory) as it tried to find the device...probably a mix of old volume-map support code and data relation handling

Is there a simpler way to test this with amulet?

As an alternative, I could try to write a unittest for the fix in config_changed_volume_apply function.


« Back to merge proposal