Juju Charms Collection
haproxy package

Code review comment for lp:~verterok/charms/trusty/haproxy/statistics-interface

  1. Trusty Tahr (14.04)
  2. statistics-interface
  3. Merge into trunk
Revision history for this message
Guillermo Gonzalez (verterok) wrote :

Hi Andrew,

> Hi Guillermo,
>
> So, bundletester still passes (as expected since there are no related changes)
> and a 'make build' runs through and works OK...

Thanks for looking at this.

>
> However, I wasn't sure that was enough so I deployed this and related it to
> telegraf, and didn't see any hooks fired that were clearly 'statistics
> interface' related - I assume this is because I didn't relate them
> specifically enough, but would you be able to provide some instructions on how
> I can do this to make sure the hooks are firing correctly and successfully?
>
> http://pastebin.ubuntu.com/15347650/

You'r right, there is no support for statistics interface in the telegraf charm yet, still waiting for a review on https://code.launchpad.net/~verterok/charms/trusty/telegraf/haproxy-statistics/+merge/288009
But you can test the haproxy side by using the above branch when deploying the telegraf subordinate.

The telegraf charm changes should be landed soon-ish (need to poke/chase some team mates to geta review on it)

Thanks.

« Back to merge proposal