Code review comment for ~verterok/charm-graylog:beats-lb

Revision history for this message
James Troup (elmo) wrote :

I'd personally be fine with a unit test for this, but given the typo, I do think it needs at least that. I don't object to a functional test, if you want, but given the code change, it seems like overkill to me. I'm curious about the use case?

(See comment inline.)

review: Needs Fixing

« Back to merge proposal