I'd personally be fine with a unit test for this, but given the typo, I do think it needs at least that. I don't object to a functional test, if you want, but given the code change, it seems like overkill to me. I'm curious about the use case?
(See comment inline.)
« Back to merge proposal
I'd personally be fine with a unit test for this, but given the typo, I do think it needs at least that. I don't object to a functional test, if you want, but given the code change, it seems like overkill to me. I'm curious about the use case?
(See comment inline.)