Code review comment for lp:~verifydtapn-contributers/verifydtapn/timeDartPtrie

Revision history for this message
Jakob Taankvist (jakob-taankvist) wrote :

1) The file src/DiscreteVerification/DataStructures/EncodingStructure.cpp is practically empty?

2) The lines

2569 + void Release() const {
2570 + delete[] shadow;
2571 + }

seems a little dodgy? Shouldn't this be in the destructor?

3) The file src/DiscreteVerification/DataStructures/NonStrictMarking.cpp had it's contents deleted - but the file wasn't?

4) The file src/DiscreteVerification/DataStructures/PData.cpp is practically empty?

5) The comment "//possible mem-leek?" in line 3807 seems like it should be investigated?

I don't think the above have any functional implications, but it should be fixed at some point.

review: Approve

« Back to merge proposal