Merge lp:~verb/duplicity/boto-min-version into lp:duplicity/0.6

Proposed by Lee Verberne
Status: Merged
Merged at revision: 940
Proposed branch: lp:~verb/duplicity/boto-min-version
Merge into: lp:duplicity/0.6
Diff against target: 38 lines (+3/-3)
3 files modified
README (+1/-1)
duplicity/backends/_boto_multi.py (+1/-1)
duplicity/backends/_boto_single.py (+1/-1)
To merge this branch: bzr merge lp:~verb/duplicity/boto-min-version
Reviewer Review Type Date Requested Status
Kenneth Loafman Approve
edso Pending
Review via email: mp+182014@code.launchpad.net

Description of the change

This updates documentation and error messages to match the current actual version requirements of boto backend.

To post a comment you must log in.
Revision history for this message
edso (ed.so) wrote :

can you update the manpage 'bin/duplicity.1', section REQUIREMENTS as well please?

just curious, why odes multi_boto need 2.1.1 instead of 2.0 ?

..ede/duply.net

Revision history for this message
Lee Verberne (verb) wrote :

I hadn't noticed it before, but the man page already reflects a boto requirement of 2.0+.

I haven't submitted any work on boto_multi, but the README said the minimum version was 2.1.1, I added it to boto_multi for consistency. In retrospect, it seems pretty unlikely that the minimum version is actually 2.1.1.

According to the release notes, 2.1.1 is a bugfix release that only affects RDS. 2.1.0 doesn't list any changes for multipart upload, either. boto_multi may only require 2.0. I'll test it with 2.0.

Revision history for this message
edso (ed.so) wrote :

On 26.08.2013 16:27, Lee Verberne wrote:
> I hadn't noticed it before, but the man page already reflects a boto requirement of 2.0+.
>
> I haven't submitted any work on boto_multi, but the README said the minimum version was 2.1.1, I added it to boto_multi for consistency. In retrospect, it seems pretty unlikely that the minimum version is actually 2.1.1.
>
> According to the release notes, 2.1.1 is a bugfix release that only affects RDS. 2.1.0 doesn't list any changes for multipart upload, either. boto_multi may only require 2.0. I'll test it with 2.0.
>

right, the README doesn't get that much love.. we should actually sync manpage requirements section into README, as it is much more up to date.

please do and update your branch accordingly .. thanks ede/duply.net

Revision history for this message
Kenneth Loafman (kenneth-loafman) wrote :

What is the status of this?

Revision history for this message
edso (ed.so) wrote :

On 17.11.2013 18:30, Kenneth Loafman wrote:
> What is the status of this?
>

waiting on confirmation and fixes that we talked about in the comments above. so - incomplete - so far.

..ede

Revision history for this message
Kenneth Loafman (kenneth-loafman) wrote :

Just making sure. Thanks.

On Sun, Nov 17, 2013 at 11:36 AM, edso <email address hidden> wrote:

> On 17.11.2013 18:30, Kenneth Loafman wrote:
> > What is the status of this?
> >
>
> waiting on confirmation and fixes that we talked about in the comments
> above. so - incomplete - so far.
>
> ..ede
>
> --
> https://code.launchpad.net/~verb/duplicity/boto-min-version/+merge/182014
> You are subscribed to branch lp:duplicity.
>

Revision history for this message
Kenneth Loafman (kenneth-loafman) wrote :

He finished it.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'README'
2--- README 2012-10-15 17:25:38 +0000
3+++ README 2013-08-25 23:54:25 +0000
4@@ -25,7 +25,7 @@
5 * for scp/sftp -- python-paramiko and python-pycryptopp
6 * for normal ftp -- NcFTP version 3.1.9 or later, but not 3.2.0
7 * for ftp over SSL -- lftp version 3.7.15 or later
8- * Boto 1.6a or later for single-processing S3 access (default)
9+ * Boto 2.0 or later for single-processing S3 or GCS access (default)
10 * Boto 2.1.1 or later for multi-processing S3 access
11 * Python v2.6 or later for multi-processing S3 access
12
13
14=== modified file 'duplicity/backends/_boto_multi.py'
15--- duplicity/backends/_boto_multi.py 2013-01-25 13:35:33 +0000
16+++ duplicity/backends/_boto_multi.py 2013-08-25 23:54:25 +0000
17@@ -36,7 +36,7 @@
18 from duplicity.filechunkio import FileChunkIO
19 from duplicity import progress
20
21-BOTO_MIN_VERSION = "1.6a"
22+BOTO_MIN_VERSION = "2.1.1"
23
24 # Multiprocessing is not supported on *BSD
25 if sys.platform not in ('darwin', 'linux2'):
26
27=== modified file 'duplicity/backends/_boto_single.py'
28--- duplicity/backends/_boto_single.py 2013-07-19 22:38:23 +0000
29+++ duplicity/backends/_boto_single.py 2013-08-25 23:54:25 +0000
30@@ -29,7 +29,7 @@
31 from duplicity.backend import retry
32 from duplicity import progress
33
34-BOTO_MIN_VERSION = "1.6a"
35+BOTO_MIN_VERSION = "2.0"
36
37
38 class BotoBackend(duplicity.backend.Backend):

Subscribers

People subscribed via source and target branches

to all changes: