Code review comment for lp:~veebers/autopilot/recursive-object-tree

Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

Still need to do:

1) Update docstring to mention that:
  a) The search is recursive
  b) The search starts with the node you call this method on.
  c) You must either specify a type name, or keyword parameters, or both.
     i) When this happens. Raise an exception.
     ii) Show doctest examples in the docstring for each scenarios.

2) Fix copyright header in autopilot/tests/test_dbus_query. Merge autopilot trunk and copy a header from another python file.

3) Fix docstring formatting on diff line 151 - closing quotes should be on a line by themselves, preceeded by a newline.

Things that are not tested:

Calling select_single with:
 * neither type name nor keyword parameters specified.
 * Type name specified that does not match anything in the tree (should return None)
 * keyword arguments specified that does not match anything in the tree (should return None)

Calling select single with a query that returns more than one item (must raise ValueError).

Calling select_many with:
 * Neither type name nor keyword arguments specified.
 * kwargs only.
 * a query that returns nothing.

review: Needs Fixing

« Back to merge proposal