Merge lp:~veebers/autopilot/fix-upstart-rename-1330803 into lp:autopilot

Proposed by Christopher Lee
Status: Merged
Approved by: Christopher Lee
Approved revision: 524
Merged at revision: 494
Proposed branch: lp:~veebers/autopilot/fix-upstart-rename-1330803
Merge into: lp:autopilot
Diff against target: 39 lines (+8/-3)
2 files modified
autopilot/application/_launcher.py (+6/-1)
debian/control (+2/-2)
To merge this branch: bzr merge lp:~veebers/autopilot/fix-upstart-rename-1330803
Reviewer Review Type Date Requested Status
Robert Bruce Park (community) Approve
PS Jenkins bot continuous-integration Approve
Thomi Richards (community) Approve
Review via email: mp+223486@code.launchpad.net

This proposal supersedes a proposal from 2014-06-17.

Commit message

Change build deps and import attempt so autopilot is runnable/build-able on Trusty. (due to upstart-app-launch -> ubuntu-app-launch rename)

Description of the change

(Resubmitted to target the correct branch.)
Make autopilot build-able and runnable in Trusty (due to upstart-app-launch -> ubuntu-app-launch rename).

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) wrote : Posted in a previous version of this proposal

This makes sense to me.

Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

LGTM

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:524
http://jenkins.qa.ubuntu.com/job/autopilot-ci/744/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-amd64-ci/18
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-amd64-ci/18/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-armhf-ci/18
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-armhf-ci/18/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-i386-ci/18
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-i386-ci/18/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic-autopilot/141
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic-touch/167
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic-autopilot/233
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1017
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1017/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/1732
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/1732/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/6815
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/8551

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/744/rebuild

review: Approve (continuous-integration)
Revision history for this message
Robert Bruce Park (robru) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'autopilot/application/_launcher.py'
2--- autopilot/application/_launcher.py 2014-06-12 22:37:24 +0000
3+++ autopilot/application/_launcher.py 2014-06-17 22:27:45 +0000
4@@ -20,7 +20,12 @@
5 """Base module for application launchers."""
6
7 import fixtures
8-from gi.repository import GLib, UbuntuAppLaunch
9+from gi.repository import GLib
10+try:
11+ from gi.repository import UbuntuAppLaunch
12+except ImportError:
13+ # Note: the renamed package is not in Trusty.
14+ from gi.repository import UpstartAppLaunch as UbuntuAppLaunch
15 import json
16 import logging
17 import os
18
19=== modified file 'debian/control'
20--- debian/control 2014-05-29 16:43:08 +0000
21+++ debian/control 2014-06-17 22:27:45 +0000
22@@ -9,7 +9,7 @@
23 gir1.2-gconf-2.0,
24 gir1.2-gtk-3.0,
25 gir1.2-ibus-1.0,
26- gir1.2-ubuntu-app-launch-2,
27+ gir1.2-ubuntu-app-launch-2 | gir1.2-upstart-app-launch-2,
28 graphviz,
29 libjs-jquery,
30 libjs-underscore,
31@@ -42,7 +42,7 @@
32 Architecture: all
33 Depends: ${misc:Depends},
34 ${python3:Depends},
35- gir1.2-ubuntu-app-launch-2,
36+ gir1.2-ubuntu-app-launch-2 | gir1.2-upstart-app-launch-2,
37 libjs-underscore, libjs-jquery,
38 python3-dbus,
39 python3-decorator,

Subscribers

People subscribed via source and target branches