Merge lp:~veebers/autopilot/fix-upstart-rename-1330803 into lp:~autopilot/autopilot/temp-dev

Proposed by Christopher Lee
Status: Superseded
Proposed branch: lp:~veebers/autopilot/fix-upstart-rename-1330803
Merge into: lp:~autopilot/autopilot/temp-dev
Diff against target: 39 lines (+8/-3)
2 files modified
autopilot/application/_launcher.py (+6/-1)
debian/control (+2/-2)
To merge this branch: bzr merge lp:~veebers/autopilot/fix-upstart-rename-1330803
Reviewer Review Type Date Requested Status
Autopilot Hackers Pending
Review via email: mp+223342@code.launchpad.net

This proposal has been superseded by a proposal from 2014-06-17.

Commit message

Change build deps and import attempt so autopilot is runnable/build-able on Trusty. (due to upstart-app-launch -> ubuntu-app-launch rename)

Description of the change

Make autopilot build-able and runnable in Trusty (due to upstart-app-launch -> ubuntu-app-launch rename).

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) wrote :

This makes sense to me.

Unmerged revisions

524. By Christopher Lee

Change build depends so we can build on trusty (rename from upstart-app-launch -> ubuntu-app-launch) as well as import rename if needed.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'autopilot/application/_launcher.py'
2--- autopilot/application/_launcher.py 2014-06-12 22:37:24 +0000
3+++ autopilot/application/_launcher.py 2014-06-17 04:31:58 +0000
4@@ -20,7 +20,12 @@
5 """Base module for application launchers."""
6
7 import fixtures
8-from gi.repository import GLib, UbuntuAppLaunch
9+from gi.repository import GLib
10+try:
11+ from gi.repository import UbuntuAppLaunch
12+except ImportError:
13+ # Note: the renamed package is not in Trusty.
14+ from gi.repository import UpstartAppLaunch as UbuntuAppLaunch
15 import json
16 import logging
17 import os
18
19=== modified file 'debian/control'
20--- debian/control 2014-05-29 16:43:08 +0000
21+++ debian/control 2014-06-17 04:31:58 +0000
22@@ -9,7 +9,7 @@
23 gir1.2-gconf-2.0,
24 gir1.2-gtk-3.0,
25 gir1.2-ibus-1.0,
26- gir1.2-ubuntu-app-launch-2,
27+ gir1.2-ubuntu-app-launch-2 | gir1.2-upstart-app-launch-2,
28 graphviz,
29 libjs-jquery,
30 libjs-underscore,
31@@ -42,7 +42,7 @@
32 Architecture: all
33 Depends: ${misc:Depends},
34 ${python3:Depends},
35- gir1.2-ubuntu-app-launch-2,
36+ gir1.2-ubuntu-app-launch-2 | gir1.2-upstart-app-launch-2,
37 libjs-underscore, libjs-jquery,
38 python3-dbus,
39 python3-decorator,

Subscribers

People subscribed via source and target branches