Code review comment for lp:~vds/usso/support_sha1

> Thanks for doing this! I have some notes. I don't know how urgent they are,
> since AIUI this code isn't functional yet, so perhaps it's best to land the
> code anyway, and then address any remaining points in a later branch. Maybe
> put TODO or XXX markers in the code? Just make sure not to forget. :)

Thanks for this notes, but, if we don't want to forget all this obeservation the right place were to put them is the google doc, once the branch is landed, no one will come back here to read the comments.
I agree with the need for better tests and error handling which has been ignored for a while, both are already listed in the google doc as next work item.

I'll fix the bugs you spotted and then I guess we can land this branch and keep improving the library in the following branches.