lp:xserver-xorg-video-intel

Created by James Westby and last modified
Get this branch:
bzr branch lp:xserver-xorg-video-intel

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
VCS imports
Project:
xf86-video-intel
Status:
Development

Import details

Import Status: Reviewed

This branch is an import of the HEAD branch of the Git repository at git://anongit.freedesktop.org/xorg/driver/xf86-video-intel.

The next import is scheduled to run .

Last successful import was .

Import started on izar and finished taking 10 seconds — see the log
Import started on izar and finished taking 10 seconds — see the log
Import started on alnitak and finished taking 10 seconds — see the log
Import started on alnitak and finished taking 15 seconds — see the log
Import started on izar and finished taking 10 seconds — see the log
Import started on alnitak and finished taking 10 seconds — see the log
Import started on alnitak and finished taking 10 seconds — see the log
Import started on izar and finished taking 10 seconds — see the log
Import started on alnitak and finished taking 10 seconds — see the log
Import started on alnitak and finished taking 15 seconds — see the log

Recent revisions

8604. By Chris Wilson on 2021-01-15

sna: Always validate userptr upon creation

Since not all memory ranges can be mapped by userptr, in particular those
passed by XShmAttachFD, we need to validate the userptr before use. We
would ideally want to continue to lazily populate the pages as often the
userptr is created but never used, but preventing an EFAULT later is
more important.

In https://patchwork.freedesktop.org/series/33449/ we provided a more
efficient method for probing the userptr on construction while
preserving the lazy population of gup-pages. For now, always follow
userptr with set-domain.

Reported-by: Jinoh Kang <email address hidden>
Signed-off-by: Chris Wilson <email address hidden>

8603. By Chris Wilson on 2021-01-10

sna/gen7: Avoid clear-residuals overhead on all gen7

Since not just Haswell will enjoy clear-residuals, be very careful
before using a potential context switch from DRI clients.

Signed-off-by: Chris Wilson <email address hidden>

8602. By Chris Wilson on 2020-12-15

sna: Enable TearFree by default on recent HW

When there is ample memory bandwidth and we are not fighting for global
resources, enable TearFree by default. Avoiding tearing is much more
pleasant (for direct rendering where the source itself is not being
synchronized to vblank) at negligible power cost; just doubles the
memory footprint of scanout.

References: https://gitlab.freedesktop.org/drm/intel/-/issues/2799
References: https://gitlab.freedesktop.org/drm/intel/-/issues/2763
Signed-off-by: Chris Wilson <email address hidden>

8601. By Chris Wilson on 2020-11-26

sna: Defer fbGetWindowPixmap() for sna_composite

Mike Lothian ran into a surprising situation where compScreenUpdate was
calling CompositePicture without a pixmap attached to the destination
Window, and so we found ourselves chasing a NULL PixmapPtr.

  #1 to_sna_from_pixmap (pixmap=0x0) at sna.h:521
  #2 sna_composite (op=<optimized out>, src=0x55b3346c1420, mask=0x0,
      dst=0x55b3346c1d50, src_x=<optimized out>, src_y=<optimized out>, mask_x=0,
      mask_y=0, dst_x=0, dst_y=0, width=3840, height=2160) at sna_composite.c:652
  #3 0x000055b33202c208 in damageComposite (op=<optimized out>,
      pSrc=0x55b3346c1420, pMask=0x0, pDst=0x55b3346c1d50, xSrc=<optimized out>,
      ySrc=<optimized out>, xMask=0, yMask=0, xDst=0, yDst=0, width=3840,
      height=2160) at damage.c:513
  #4 0x000055b33201820c in CompositePicture (op=<optimized out>,
      op@entry=1 '\001', pSrc=pSrc@entry=0x55b3346c1420, pMask=pMask@entry=0x0,
      pDst=pDst@entry=0x55b3346c1d50, xSrc=xSrc@entry=0, ySrc=ySrc@entry=0,
      xMask=0, yMask=0, xDst=0, yDst=0, width=3840, height=2160) at picture.c:1547
  #5 0x000055b331fc85d3 in compWindowUpdateAutomatic (
      pWin=pWin@entry=0x55b3343a6bc0) at compwindow.c:705
  #6 0x000055b331fca029 in compPaintWindowToParent (pWin=pWin@entry=0x55b3343a6bc0)
      at compwindow.c:729
  #7 0x000055b331fc9fbb in compPaintChildrenToWindow (pWin=0x55b333e77b50)
      at compwindow.c:744
  #8 0x000055b331fca59f in compScreenUpdate (pClient=<optimized out>,
      closure=<optimized out>) at compalloc.c:57
  #9 0x000055b331f3abf4 in ProcessWorkQueue () at dixutils.c:536
  #10 0x000055b3320aaa51 in WaitForSomething (are_ready=<optimized out>)
      at WaitFor.c:192
  #11 0x000055b331f361a9 in Dispatch () at dispatch.c:421
  #12 0x000055b331f39cec in dix_main (argc=13, argv=0x7ffcf273f538,
      envp=<optimized out>) at main.c:276
  #13 0x000055b331f247de in main (argc=<optimized out>, argv=<optimized out>,
      envp=<optimized out>) at stubmain.c:34

Fortuitously, that drawable was also fully clipped so that it took an
early exit and so we can hide the segfault by delaying querying the
pixmap until after the clip check.

The ongoing mystery is how we ended up in that state in the first place.

Closes: https://gitlab.freedesktop.org/xorg/driver/xf86-video-intel/-/issues/204
Signed-off-by: Chris Wilson <email address hidden>

8600. By Chris Wilson on 2020-11-16

More ABI changes for ABI_VIDEODRV_VERSION 25.2

Descending down into the naming changes, onto the next struct in the
chain.

Signed-off-by: Chris Wilson <email address hidden>

8599. By Chris Wilson on 2020-11-16

Track ABI changes for ABI_VIDEODRV_VERSION 25.2

Several structs had fields renamed, and so we must update our usage.

Signed-off-by: Chris Wilson <email address hidden>

8598. By Chris Wilson on 2020-08-20

sna/gen7: Prefer blitter for plain copies on Haswell

Since the clear-residuals security fix on gen7, context switches are
very slow. If X is being used with DRI clients, those clients will
typically be using the 3D engine for themselves and every frame
presented will then be copied by X, causing at least a couple of context
switches per frame. That greatly diminishes throughput, but if we prefer
to use the blitter engine for X, we can mostly keep off the render engine
avoiding the context thrash.

Reported-by: Rafael Ristovski <email address hidden>
Signed-off-by: Chris Wilson <email address hidden>

8597. By Ville Syrjälä <email address hidden> on 2020-05-15

sna/video/overlay: Declare support for depth 8 and 30

Add 8 and 30 to the list of supported screen depths. The colorkey
massaging will be handled by the kernel so we don't have to worry
about it unlike with the sprite colorkey uapi.

Signed-off-by: Ville Syrjälä <email address hidden>
Signed-off-by: Chris Wilson <email address hidden>

8596. By Chris Wilson on 2020-05-11

sna: Avoid selecting gen9 backend for future gen

Cannonlake, then Icelake introduce new instruction formats and state
command, and require a new render backend to be written. Avoid selecting
the gen9 backend as this will hang!

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1864
Fixes: 3d5a1238af6a ("sna: Restore blt fallback backend")
Signed-off-by: Chris Wilson <email address hidden>

8595. By Chris Wilson on 2020-05-06

sna/dri2: Prevent copying stale buffers

The back buffer of window/pixmap is invalidated by DRI2ScheduleSwap, and
is not available until the client calls DRI2GetBuffers. If they try to
use their old handles, they will only get stale data. Similarly if they
ask us to DRI2CopyRegion before the GetBuffers has reallocated a new
back buffer, that back buffer is stale. Since the back buffer is
out-of-date [likely containing data from a couple of swaps ago], we
should ignore the copy to avoid glitching [by hopefully having a less
noticeable glitch!] It's not entirely clear what the client intended at
this point...

Closes: https://gitlab.freedesktop.org/xorg/driver/xf86-video-intel/-/issues/195
Signed-off-by: Chris Wilson <email address hidden>

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.

Subscribers