bochecha/srcdir-builddir : lp:~vcs-imports/librsvg/+git/librsvg : Git : Code : librsvg

Get this branch:: git clone -b bochecha/srcdir-builddir https://git.launchpad.net/~vcs-imports/librsvg/+git/librsvg

Branch information

2350612... by Jordan Petridis <email address hidden> on 2018-09-10

CI: run make && make check

When running just make check, bindings and doc generation where
being skipped.

ci: Build with srcdir != builddir

This should prevent issues like the one fixed in the previous commit to
creep back in.

build: Fix building with srcdir != builddir

This came up in the Freedesktop-Sdk project:

ViewParams: keep a Weak reference to the view box stack, not a strong one

This lets us be extra-paranoid about not dropping a ViewParams after
the corresponding DrawingCtx has been dropped.

Docs for push_view_box()

Remove unused variable

Remove DrawingCtx::pop_view_box() in favor of an impl Drop for it

ViewParams and DrawingCtx now store an Rc<RefCell<...>> of the
view_box_stack.

Thanks to Antoni Boucher for the suggestion on how to avoid lifetimes here.

DrawingCtx: store the view_box_stack in a RefCell

So that push_view_box()/pop_view_box() don't need a mutable draw_ctx.

This should help with the Drop impl next.

DrawingCtx: Keep the whole stack of viewboxes in the view_box_stack

We used to keep the element at the top of the stack in a separate
field, which is a bit awkward.

DrawingCtx: rename vb_stack field to view_box_stack

»