If a hidden weak symbol isn't defined in the TU, we can't assume it will
be defined in another TU at link time. It makes a difference in code
generation when compiling for PIC. If we assume that a hidden weak
undefined symbol is local, the address checking may be optimized out and
leads to the wrong code. This means that a symbol with user specified
visibility is local only if it is locally resolved or defined, not weak
or not compiling for PIC. When symbol visibility is specified in the
source, we should always output symbol visibility even if symbol isn't
local to the TU.
If a global data symbol is defined in the TU, it is always local to the
executable, regardless if it is a common symbol or not. If we aren't
compiling for shared library, locally defined global data symbol binds
locally.
Since some targets call default_binds_local_p_1 directly and depend on
the old behavior of default_binds_local_p_1. This patch copies
default_binds_local_p_1 to default_binds_local_p_2 and changes the
behavior of default_binds_local_p by calling default_binds_local_p_2
instead of default_binds_local_p_1.
gcc/
PR rtl-optimization/32219
* cgraphunit.c (varpool_node::finalize_decl): Set definition
first before calling notice_global_symbol so that it is
available to notice_global_symbol.
* varasm.c (default_binds_local_p_2): Copied from
default_binds_local_p_1. Resolve defined data symbol locally if
not building shared library. Resolve symbol with user specified
visibility locally only if it is locally resolved or defined, not
weak or not compiling for PIC.
(default_binds_local_p): Replace default_binds_local_p_1 with
default_binds_local_p_2.
(default_elf_asm_output_external): Always output visibility
specified in the source.
34b620b...
by
mwahab <mwahab@138bc75d-0d04-0410-961f-82ee72b054a4>
* testsuite/28_regex/traits/char/isctype.cc (test01): Replace test
for __NEWLIB__ macro with a dejagnu set macro.
* testsuite/28_regex/traits/wchar_t/isctype.cc (test01): Likewise.
ca5b5c7...
by
jakub <jakub@138bc75d-0d04-0410-961f-82ee72b054a4>
PR tree-optimization/65014
* fold-const.c (fold_binary_loc): When creating {L,R}ROTATE_EXPR,
use original second operand of arg0 or arg1 instead of
that adjusted by STRIP_NOPS.
