Code review comment for lp:~vbkaisetsu/tomdroid/sql-args

Revision history for this message
Olivier Bilodeau (plaxx) wrote :

Doesn't automatically upgrade the SQL database. This can't be merged as-is.

Also, I would like to see the query arguments to be migrated into ? and selectionArgs as query() supports. docs/reference/android/database/sqlite/SQLiteDatabase.html#query(java.lang.String, java.lang.String[], java.lang.String, java.lang.String[], java.lang.String, java.lang.String, java.lang.String, java.lang.String)

review: Needs Fixing

« Back to merge proposal