Merge lp:~vauxoo/openerp-venezuela-localization/7.0-l10n_ve-yaml-fix-rev-kty into lp:openerp-venezuela-localization

Proposed by Katherine Zaoral (Vauxoo)
Status: Merged
Approved by: hbto [Vauxoo] http://www.vauxoo.com
Approved revision: 1048
Merged at revision: 1036
Proposed branch: lp:~vauxoo/openerp-venezuela-localization/7.0-l10n_ve-yaml-fix-rev-kty
Merge into: lp:openerp-venezuela-localization
Diff against target: 123 lines (+23/-6)
7 files modified
l10n_ve_withholding_islr/__openerp__.py (+8/-1)
l10n_ve_withholding_islr/model/islr_wh_doc.py (+3/-3)
l10n_ve_withholding_islr/security/ir.model.access.csv (+4/-0)
l10n_ve_withholding_islr/test/customer_wh_islr_doc.yml (+1/-0)
l10n_ve_withholding_islr/test/supplier_wh_islr_doc.yml (+2/-1)
l10n_ve_withholding_islr/test/supplier_wh_islr_invoice.yml (+5/-0)
l10n_ve_withholding_islr/view/islr_wh_concept_view.xml (+0/-1)
To merge this branch: bzr merge lp:~vauxoo/openerp-venezuela-localization/7.0-l10n_ve-yaml-fix-rev-kty
Reviewer Review Type Date Requested Status
hbto [Vauxoo] http://www.vauxoo.com Approve
Katherine Zaoral (Vauxoo) Pending
Review via email: mp+235678@code.launchpad.net

Description of the change

[MERGE] fix views warning and yaml test cases definition errors.

To post a comment you must log in.
Revision history for this message
Katherine Zaoral (Vauxoo) (kathy-zaoral) wrote :

waiting for runbot

1037. By Katherine Zaoral (Vauxoo)

[FIX] remove error field.

1038. By Katherine Zaoral (Vauxoo)

[ADD] add the propagate invoice date to income withholding attribute in the
company to make the yaml test casework with the new workflow requirements.

1039. By Katherine Zaoral (Vauxoo)

[FIX] syntax error.

1040. By Katherine Zaoral (Vauxoo)

[FIX] reference to a wrong model.

1041. By Katherine Zaoral (Vauxoo)

[FIX] missing definition of dictionary.

1042. By Katherine Zaoral (Vauxoo)

[MERGE] ovl revno 1035.

1043. By Katherine Zaoral (Vauxoo)

[REM] revert change.

1044. By hbto [Vauxoo] http://www.vauxoo.com

[FIX] Missing date in case inv_brw is None

1045. By hbto [Vauxoo] http://www.vauxoo.com

[FIX] add missing field to an yml test Wh definition.

1046. By hbto [Vauxoo] http://www.vauxoo.com

[FIX] Missing dependency on report_webkit

1047. By hbto [Vauxoo] http://www.vauxoo.com

[FIX] Missing field in YAML test
[FIX] Wrong parameter in method call

1048. By hbto [Vauxoo] http://www.vauxoo.com

[IMP] Adding Security Settings to islr.wh.historical.data model

Revision history for this message
hbto [Vauxoo] http://www.vauxoo.com (humbertoarocha) wrote :

Runbot Has Gone Green

review: Approve
Revision history for this message
Katherine Zaoral (Vauxoo) (kathy-zaoral) wrote :

great
i will proceed with the merge
regards

Revision history for this message
hbto [Vauxoo] http://www.vauxoo.com (humbertoarocha) wrote :

Merge done
On Sep 23, 2014 11:39 PM, "Katherine Zaoral (Vauxoo)" <
<email address hidden>> wrote:

> great
> i will proceed with the merge
> regards
>
> --
>
> https://code.launchpad.net/~vauxoo/openerp-venezuela-localization/7.0-l10n_ve-yaml-fix-rev-kty/+merge/235678
> You are reviewing the proposed merge of
> lp:~vauxoo/openerp-venezuela-localization/7.0-l10n_ve-yaml-fix-rev-kty into
> lp:openerp-venezuela-localization.
>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'l10n_ve_withholding_islr/__openerp__.py'
2--- l10n_ve_withholding_islr/__openerp__.py 2014-09-18 21:21:38 +0000
3+++ l10n_ve_withholding_islr/__openerp__.py 2014-09-24 01:46:47 +0000
4@@ -42,7 +42,14 @@
5 #If you want be able to propose withholding concepts from sales and purchases you must install extra module @section{l10n_ve_sale_purchase}.
6
7 ''',
8- "depends" : ["account", "l10n_ve_withholding", "l10n_ve_fiscal_requirements", "product"], # ,"edi"],
9+ "depends" : [
10+ "account",
11+ "l10n_ve_withholding",
12+ "l10n_ve_fiscal_requirements",
13+ "product",
14+ "report_webkit",
15+ # ,"edi"],
16+ ],
17 "init_xml" : [],
18 "demo_xml":[
19 "demo/l10n_ve_islr_withholding_demo.xml",
20
21=== modified file 'l10n_ve_withholding_islr/model/islr_wh_doc.py'
22--- l10n_ve_withholding_islr/model/islr_wh_doc.py 2014-09-23 18:39:45 +0000
23+++ l10n_ve_withholding_islr/model/islr_wh_doc.py 2014-09-24 01:46:47 +0000
24@@ -903,7 +903,7 @@
25 base += base_line
26
27 #rate_base, rate_minimum, rate_wh_perc, rate_subtract, rate_code, rate_id, rate_name, rate2 = self._get_rate(
28- # cr, uid, ail_brw.concept_id.id, residence, nature, inv_brw=ail_brw.invoice_id, context=context)
29+ # cr, uid, ail_brw.concept_id.id, residence, nature, base=base, inv_brw=ail_brw.invoice_id, context=context)
30 rate_tuple = self._get_rate(
31 cr, uid, concept_id, residence, nature, base=base, inv_brw=iwdl_brw.invoice_id, context=context)
32
33@@ -979,7 +979,7 @@
34 base += base_line
35
36 rate_tuple = self._get_rate(
37- cr, uid, concept_id, residence, nature, base_line=0.0, inv_brw=iwdl_brw.invoice_id, context=context)
38+ cr, uid, concept_id, residence, nature, base=0.0, inv_brw=iwdl_brw.invoice_id, context=context)
39
40 if rate_tuple[7]:
41 apply = True
42@@ -1148,7 +1148,7 @@
43 islr_rate_args = [('concept_id','=',concept_id),('nature','=',nature),('residence','=',residence),]
44 order = 'minimum desc'
45
46- date_ret = inv_brw.islr_wh_doc_id.date_uid
47+ date_ret = inv_brw and inv_brw.islr_wh_doc_id.date_uid or time.strftime('%Y-%m-%d')
48
49 concept_brw = self.pool.get('islr.wh.concept').browse(cr, uid, concept_id)
50
51
52=== modified file 'l10n_ve_withholding_islr/security/ir.model.access.csv'
53--- l10n_ve_withholding_islr/security/ir.model.access.csv 2014-06-27 21:21:30 +0000
54+++ l10n_ve_withholding_islr/security/ir.model.access.csv 2014-09-24 01:46:47 +0000
55@@ -29,3 +29,7 @@
56 access_account_islr_xml_wh_line_manager,islr.xml.wh.line.manager,model_islr_xml_wh_line,l10n_ve_withholding_islr.group_account_wh_islr_manager,1,1,1,1
57
58 access_account_islr_xml_wh_doc_manager,islr.xml.wh.doc.manager,model_islr_xml_wh_doc,l10n_ve_withholding_islr.group_account_wh_islr_manager,1,1,1,1
59+
60+access_islr_wh_historical_data_user,islr.wh.historical.data.user,model_islr_wh_historical_data,,1,1,1,0
61+
62+access_islr_wh_historical_data_manager,islr.wh.historical.data.manager,model_islr_wh_historical_data,l10n_ve_withholding_islr.group_account_wh_islr_manager,1,1,1,1
63
64=== modified file 'l10n_ve_withholding_islr/test/customer_wh_islr_doc.yml'
65--- l10n_ve_withholding_islr/test/customer_wh_islr_doc.yml 2013-12-18 20:20:04 +0000
66+++ l10n_ve_withholding_islr/test/customer_wh_islr_doc.yml 2014-09-24 01:46:47 +0000
67@@ -90,6 +90,7 @@
68 name: ISLR WH DOC (CUSTOMER MANUALLY)
69 partner_id: l10n_ve_fiscal_requirements.f_req_partner_1
70 account_id: account.a_recv
71+ date_uid: !eval time.strftime('%Y-%m-%d')
72 -
73 I unlink the auto-loaded invoices.
74 -
75
76=== modified file 'l10n_ve_withholding_islr/test/supplier_wh_islr_doc.yml'
77--- l10n_ve_withholding_islr/test/supplier_wh_islr_doc.yml 2013-12-18 20:20:04 +0000
78+++ l10n_ve_withholding_islr/test/supplier_wh_islr_doc.yml 2014-09-24 01:46:47 +0000
79@@ -867,6 +867,7 @@
80 name: ISLR SUPPLIER WH DOC (MANUAL)
81 partner_id: l10n_ve_fiscal_requirements.f_req_partner_1
82 account_id: account.a_recv
83+ date_uid: !eval time.strftime('%Y-%m-%d')
84 -
85 I unlink the auto-loaded invoices.
86 -
87@@ -895,7 +896,7 @@
88 - len(invoice_ids) == 1
89 - invoice_ids[0].invoice_id.id == ref( 'islr_manual_supplier_invoice' )
90 -
91- I compute the taxes manually with the button 'Compute Icome Withholding'.
92+ I compute the taxes manually with the button 'Compute Income Withholding'.
93 -
94 !function {model: islr.wh.doc, name: compute_amount_wh, id: islr_manual_supplier_wh_doc}:
95 - model: islr.wh.doc
96
97=== modified file 'l10n_ve_withholding_islr/test/supplier_wh_islr_invoice.yml'
98--- l10n_ve_withholding_islr/test/supplier_wh_islr_invoice.yml 2013-12-18 19:49:59 +0000
99+++ l10n_ve_withholding_islr/test/supplier_wh_islr_invoice.yml 2014-09-24 01:46:47 +0000
100@@ -8,6 +8,11 @@
101 !context
102 'type': 'in_invoice'
103 -
104+ I set the company to propagate the invoice date to income withholding.
105+-
106+ !record {model: res.company, id: base.main_company}:
107+ propagate_invoice_date_to_income_withholding: True
108+-
109 I check that the company is a income withholding agent and is at Venezuela.
110 -
111 !assert {model: res.partner, id: base.main_partner, string: The companu is a non-withholdable agent}:
112
113=== modified file 'l10n_ve_withholding_islr/view/islr_wh_concept_view.xml'
114--- l10n_ve_withholding_islr/view/islr_wh_concept_view.xml 2014-09-20 16:41:36 +0000
115+++ l10n_ve_withholding_islr/view/islr_wh_concept_view.xml 2014-09-24 01:46:47 +0000
116@@ -149,7 +149,6 @@
117 <record model="ir.actions.act_window" id="action_wh_islr_rates">
118 <field name="name">Income Withholding Rates</field>
119 <field name="res_model">islr.rates</field>
120- <field name="model"></field>
121 <field name="type">ir.actions.act_window</field>
122 <field name="view_type">form</field>
123 <field name="view_mode">tree</field>