Code review comment for lp:~vauxoo/openerp-mexico-localization/sale_payment_method_dev_luis

Revision history for this message
Moisés López - http://www.vauxoo.com (moylop260) wrote :

Luis,

En esta línea va a marcar error cuando no tenga sale asociada.
+ sale_id = self.browse(cursor, user, picking_id, context=context).sale_id.id
Cambiar por
+ sale_obj = self.browse(cursor, user, picking_id, context=context)
+ sale_id = sale_obj.sale_id and sale_obj.sale_id.id or False

Los write los puedes mandar a un solo write, solo para que quede más eficiente.
219 + invoice_obj.write(cursor, user, [invoice_id], {'acc_payment': acc_payment_id}, context=context)
220 + invoice_obj.write(cursor, user, [invoice_id], {'pay_method_id': payment_method_id}, context=context)

Cambiar a
219 + invoice_obj.write(cursor, user, [invoice_id], {'acc_payment': acc_payment_id, 'pay_method_id': payment_method_id}, context=context)

« Back to merge proposal