Merge lp:~vauxoo/openerp-mexico-localization/7.0-l10n_mx_partner_address_placeholder_dev_carlos into lp:openerp-mexico-localization/7.0

Proposed by Juan Carlos Hernandez
Status: Merged
Merged at revision: 292
Proposed branch: lp:~vauxoo/openerp-mexico-localization/7.0-l10n_mx_partner_address_placeholder_dev_carlos
Merge into: lp:openerp-mexico-localization/7.0
Diff against target: 310 lines (+159/-71)
4 files modified
l10n_mx_company_multi_address/demo/l10n_mx_company_multi_address_demo.xml (+3/-0)
l10n_mx_partner_address/i18n/es.po (+127/-43)
l10n_mx_partner_address/partner_address.py (+24/-19)
l10n_mx_partner_address/res_company_view_inherit.xml (+5/-9)
To merge this branch: bzr merge lp:~vauxoo/openerp-mexico-localization/7.0-l10n_mx_partner_address_placeholder_dev_carlos
Reviewer Review Type Date Requested Status
Moisés López - http://www.vauxoo.com Approve
Juan Carlos Hernandez Pending
Rodolfo Lopez Pending
Isaac López Zúñiga Pending
Review via email: mp+182779@code.launchpad.net

Description of the change

se corrigió la traducción para el modulo l10n_mx_partner_address para la direccion del partner y de la compañia

To post a comment you must log in.
Revision history for this message
Moisés López - http://www.vauxoo.com (moylop260) wrote :

Cuando se usa la funcion para traducir _('Texto') solo se debe de mandar la cadena que se quiere traducir. No se le debe de pasar código fuente xml.

Por ejemplo, _("placeholder='Locality...'")
Debería de ser: _("Locality...")
Es decir, solo se traduce el elemento Locality, no se debe de traducir placeholder porque esto es un token.

De igual forma, con el siguiente texto:
+ _("Returns the list of the address fields that synchronizes from the parent when the flag is set use_parent_address.")
Este documentación de la función, esto no se muestra en ningun lado en OpenERP, solo es para python y no lo mostrará traducido. dejarlo así:
"Returns the list of the address fields that synchronizes from the parent when the flag is set use_parent_address."

review: Needs Fixing
Revision history for this message
Moisés López - http://www.vauxoo.com (moylop260) wrote :

Asegurarse de que primero aparezca el número exterior y luego el número interior (en ese orden) en la vista y no al revés.

review: Needs Fixing
273. By Juan Carlos Hernandez

[MERGE]

274. By Juan Carlos Hernandez

[MERGE]

275. By Juan Carlos Hernandez

[IMP]

276. By Juan Carlos Hernandez

[IMP][l10n_mx_partner_address]fix translation without placehorlder

277. By Juan Carlos Hernandez

[IMP][l10n_mx_partner_address]fix es.po and revert in res_company.py

Revision history for this message
Moisés López - http://www.vauxoo.com (moylop260) wrote :
review: Needs Fixing
278. By Juan Carlos Hernandez

[MERGE]

Revision history for this message
Juan Carlos Hernandez (openerp1) wrote :

Moy.
Ese es porque le faltan de llenar esos campos, los lleno con data demo?

2013/9/11 Moisés López - http://www.vauxoo.com <email address hidden>

> Review: Needs Fixing
>
> Está marcando este problema
>
> https://docs.google.com/file/d/0BwPeHBuUYqNsZlFKRFpSdk5OdU0/edit?usp=drivesdk
> --
>
> https://code.launchpad.net/~vauxoo/openerp-mexico-localization/7.0-l10n_mx_partner_address_placeholder_dev_carlos/+merge/182779
> You proposed
> lp:~vauxoo/openerp-mexico-localization/7.0-l10n_mx_partner_address_placeholder_dev_carlos
> for merging.
>

279. By Juan Carlos Hernandez

[ADD][l10n_mx_company_multi_address_demo]add data demo for state and country and your city

Revision history for this message
Moisés López - http://www.vauxoo.com (moylop260) wrote :

Sí por favor.

2013/9/11 Juan Carlos Hernandez Funes <email address hidden>

> Moy.
> Ese es porque le faltan de llenar esos campos, los lleno con data demo?
>
>
> 2013/9/11 Moisés López - http://www.vauxoo.com <email address hidden>
>
> > Review: Needs Fixing
> >
> > Está marcando este problema
> >
> >
> https://docs.google.com/file/d/0BwPeHBuUYqNsZlFKRFpSdk5OdU0/edit?usp=drivesdk
> > --
> >
> >
> https://code.launchpad.net/~vauxoo/openerp-mexico-localization/7.0-l10n_mx_partner_address_placeholder_dev_carlos/+merge/182779
> > You proposed
> >
> lp:~vauxoo/openerp-mexico-localization/7.0-l10n_mx_partner_address_placeholder_dev_carlos
> > for merging.
> >
>
> --
>
> https://code.launchpad.net/~vauxoo/openerp-mexico-localization/7.0-l10n_mx_partner_address_placeholder_dev_carlos/+merge/182779
> You are reviewing the proposed merge of
> lp:~vauxoo/openerp-mexico-localization/7.0-l10n_mx_partner_address_placeholder_dev_carlos
> into lp:openerp-mexico-localization/7.0.
>

--
Moisés López Calderón
Vauxoo - OpenERP's Gold Partner
mobile: (+521) 477-752-22-30
Tel: (+52) 477-773-33-46
skype: moylop260
web: http://www.vauxoo.com
twitter: @moylop260
            @vauxoo

280. By Juan Carlos Hernandez

[MERGE]

Revision history for this message
Moisés López - http://www.vauxoo.com (moylop260) wrote :

Hacer el siguiente cambio

ANTES
locality = _("'Locality...'")
placeholder= %s %(locality)

CAMBIO
locality = _('Locality...')
placeholder="%s"%(locality)

review: Needs Fixing
281. By Juan Carlos Hernandez

[IMP][l10n_mx_partner_address]fix translate

Revision history for this message
Moisés López - http://www.vauxoo.com (moylop260) wrote :

Aprobado

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'l10n_mx_company_multi_address/demo/l10n_mx_company_multi_address_demo.xml'
2--- l10n_mx_company_multi_address/demo/l10n_mx_company_multi_address_demo.xml 2013-08-05 18:35:43 +0000
3+++ l10n_mx_company_multi_address/demo/l10n_mx_company_multi_address_demo.xml 2013-09-12 22:20:12 +0000
4@@ -28,6 +28,9 @@
5
6 <record id="base.main_company" model="res.company">
7 <field name="address_invoice_parent_company_id" ref="main_mx_address_company"/>
8+ <field name="city">tu ciudad</field>
9+ <field name="state_id" ref="l10n_mx_states.res_country_state_mx_gto" model="res.country.state"/>
10+ <field name="country_id" ref="base.mx"/>
11 </record>
12
13 </data>
14
15=== modified file 'l10n_mx_partner_address/i18n/es.po'
16--- l10n_mx_partner_address/i18n/es.po 2013-08-31 05:31:25 +0000
17+++ l10n_mx_partner_address/i18n/es.po 2013-09-12 22:20:12 +0000
18@@ -1,48 +1,132 @@
19-# Spanish translation for openerp-mexico-localization
20-# Copyright (c) 2013 Rosetta Contributors and Canonical Ltd 2013
21-# This file is distributed under the same license as the openerp-mexico-localization package.
22-# FIRST AUTHOR <EMAIL@ADDRESS>, 2013.
23+# Translation of OpenERP Server.
24+# This file contains the translation of the following modules:
25+# * l10n_mx_partner_address
26 #
27 msgid ""
28 msgstr ""
29-"Project-Id-Version: openerp-mexico-localization\n"
30-"Report-Msgid-Bugs-To: FULL NAME <EMAIL@ADDRESS>\n"
31-"POT-Creation-Date: 2011-10-29 17:44+0000\n"
32-"PO-Revision-Date: 2013-08-07 17:09+0000\n"
33-"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
34-"Language-Team: Spanish <es@li.org>\n"
35+"Project-Id-Version: OpenERP Server 7.0\n"
36+"Report-Msgid-Bugs-To: \n"
37+"POT-Creation-Date: 2013-09-10 00:25+0000\n"
38+"PO-Revision-Date: 2013-09-10 00:25+0000\n"
39+"Last-Translator: <>\n"
40+"Language-Team: \n"
41 "MIME-Version: 1.0\n"
42 "Content-Type: text/plain; charset=UTF-8\n"
43-"Content-Transfer-Encoding: 8bit\n"
44-"X-Launchpad-Export-Date: 2013-08-31 05:31+0000\n"
45-"X-Generator: Launchpad (build 16750)\n"
46-
47-#. module: l10n_mx_partner_address
48-#: field:res.partner.address,city2:0
49-msgid "City2"
50-msgstr ""
51-
52-#. module: l10n_mx_partner_address
53-#: field:res.partner.address,street3:0
54-msgid "Street3"
55-msgstr ""
56-
57-#. module: l10n_mx_partner_address
58-#: field:res.partner.address,street4:0
59-msgid "Street4"
60-msgstr ""
61-
62-#. module: base
63-#: field:res.partner.address,street:0
64-msgid "Street"
65-msgstr ""
66-
67-#. module: base
68-#: field:res.partner.address,street2:0
69-msgid "Street2"
70-msgstr ""
71-
72-#. module: base
73-#: field:res.partner.address,state_id:0
74-msgid "Fed. State"
75-msgstr ""
76+"Content-Transfer-Encoding: \n"
77+"Plural-Forms: \n"
78+
79+#. module: l10n_mx_partner_address
80+#: code:addons/l10n_mx_partner_address/partner_address.py:66
81+#, python-format
82+msgid "Street..."
83+msgstr "Calle..."
84+
85+#. module: l10n_mx_partner_address
86+#: help:res.company,l10n_mx_street4:0
87+#: help:res.partner,l10n_mx_street4:0
88+msgid "Internal number of the partner address"
89+msgstr "Número interior de la dirección de la empresa"
90+
91+#. module: l10n_mx_partner_address
92+#: code:addons/l10n_mx_partner_address/partner_address.py:69
93+#, python-format
94+msgid "State"
95+msgstr "Estado"
96+
97+#. module: l10n_mx_partner_address
98+#: code:addons/l10n_mx_partner_address/partner_address.py:70
99+#, python-format
100+msgid "No External..."
101+msgstr "No Exterior..."
102+
103+#. module: l10n_mx_partner_address
104+#: code:addons/l10n_mx_partner_address/partner_address.py:67
105+#, python-format
106+msgid "Colony..."
107+msgstr "Colonia..."
108+
109+#. module: l10n_mx_partner_address
110+#: view:res.company:0
111+msgid "No. Internal..."
112+msgstr "No. Interior..."
113+
114+#. module: l10n_mx_partner_address
115+#: view:res.company:0
116+msgid "No. External..."
117+msgstr "No. Exterior..."
118+
119+#. module: l10n_mx_partner_address
120+#: field:res.company,l10n_mx_city2:0
121+#: field:res.partner,l10n_mx_city2:0
122+msgid "Locality"
123+msgstr "Localidad"
124+
125+#. module: l10n_mx_partner_address
126+#: model:ir.model,name:l10n_mx_partner_address.model_res_company
127+msgid "Companies"
128+msgstr "Compañías"
129+
130+#. module: l10n_mx_partner_address
131+#: code:addons/l10n_mx_partner_address/partner_address.py:73
132+#, python-format
133+msgid "City..."
134+msgstr "Ciudad..."
135+
136+#. module: l10n_mx_partner_address
137+#: code:addons/l10n_mx_partner_address/partner_address.py:65
138+#, python-format
139+msgid "Locality..."
140+msgstr "Localidad..."
141+
142+#. module: l10n_mx_partner_address
143+#: view:res.company:0
144+msgid "Locality"
145+msgstr "Localidad"
146+
147+#. module: l10n_mx_partner_address
148+#: field:res.company,l10n_mx_street3:0
149+#: field:res.partner,l10n_mx_street3:0
150+msgid "No. External"
151+msgstr "No. Exterior"
152+
153+#. module: l10n_mx_partner_address
154+#: help:res.company,l10n_mx_city2:0
155+#: help:res.partner,l10n_mx_city2:0
156+msgid "Locality configurated for this partner"
157+msgstr "Localidad configurada para esta empresa"
158+
159+#. module: l10n_mx_partner_address
160+#: code:addons/l10n_mx_partner_address/partner_address.py:68
161+#, python-format
162+msgid "ZIP"
163+msgstr "C.P."
164+
165+#. module: l10n_mx_partner_address
166+#: model:ir.model,name:l10n_mx_partner_address.model_res_partner
167+msgid "Partner"
168+msgstr "Empresa"
169+
170+#. module: l10n_mx_partner_address
171+#: code:addons/l10n_mx_partner_address/partner_address.py:71
172+#, python-format
173+msgid "No Internal..."
174+msgstr "No Interior..."
175+
176+#. module: l10n_mx_partner_address
177+#: field:res.company,l10n_mx_street4:0
178+#: field:res.partner,l10n_mx_street4:0
179+msgid "No. Internal"
180+msgstr "No. Interior"
181+
182+#. module: l10n_mx_partner_address
183+#: help:res.company,l10n_mx_street3:0
184+#: help:res.partner,l10n_mx_street3:0
185+msgid "External number of the partner address"
186+msgstr "Número exterior de la dirección de la empresa"
187+
188+#. module: l10n_mx_partner_address
189+#: code:addons/l10n_mx_partner_address/partner_address.py:72
190+#, python-format
191+msgid "Country..."
192+msgstr "País..."
193+
194
195=== modified file 'l10n_mx_partner_address/partner_address.py'
196--- l10n_mx_partner_address/partner_address.py 2013-08-15 21:23:09 +0000
197+++ l10n_mx_partner_address/partner_address.py 2013-09-12 22:20:12 +0000
198@@ -48,8 +48,7 @@
199 }
200
201 def _address_fields(self, cr, uid, context=None):
202- "Devuelve la lista de los campos de dirección que se sincronizan\
203- desde el padre cuando se establece la bandera `use_parent_address."
204+ "Returns the list of the address fields that synchronizes from the parent when the flag is set use_parent_address."
205 res = super(res_partner, self)._address_fields(cr, uid, context=None)
206 res.extend(['l10n_mx_street3', 'l10n_mx_street4', 'l10n_mx_city2'])
207 return res
208@@ -63,17 +62,23 @@
209 return id
210
211 def fields_view_get_address(self, cr, uid, arch, context={}):
212- res = super(res_partner, self).fields_view_get_address(
213- cr, uid, arch, context=context)
214+ locality = _('Locality...')
215+ street = _('Street...')
216+ street2 = _('Colony...')
217+ cp = _('ZIP')
218+ state = _('State')
219+ external = _('No External...')
220+ internal = _('No Internal...')
221+ country = _('Country...')
222+ city2 = _('City...')
223+ res = super(res_partner, self).fields_view_get_address(cr, uid, arch, context=context)
224 user_obj = self.pool.get('res.users')
225- fmt = user_obj.browse(
226- cr, SUPERUSER_ID, uid, context).company_id.country_id
227+ fmt = user_obj.browse(cr, SUPERUSER_ID, uid, context).company_id.country_id
228 fmt = fmt and fmt.address_format
229- city = '<field name="city" placeholder="City" style="width: 40%%"/>'
230+ city = '<field name="city" placeholder="%s" style="width: 40%%"/>' % (city2)
231 for name, field in self._columns.items():
232 if name == 'city_id':
233- city = '<field name="city" modifiers="{&quot;invisible&quot;: true}" placeholder="City....." style="width: 50%%"/><field name="city_id" on_change="onchange_city(city_id)" placeholder="City" style="width: 40%%"/>'
234-
235+ city = '<field name="city" modifiers="{&quot;invisible&quot;: true}" placeholder="%s" style="width: 50%%"/><field name="city_id" on_change="onchange_city(city_id)" placeholder="%s" style="width: 40%%"/>' % (city2, city2)
236 layouts = {
237 '%(l10n_mx_street3)s\n%(l10n_mx_street4)s\n%(l10n_mx_city2)s': """
238 <group>
239@@ -89,17 +94,17 @@
240
241 <label for="street" string="Address"/>
242 <div>
243- <field name="street" placeholder="Street..."/>
244- <field name="l10n_mx_street4" placeholder="No. Interior..."/>
245- <field name="l10n_mx_street3" placeholder="No. Exterior..."/>
246- <field name="street2" placeholder="Colonia..."/>
247+ <field name="street" placeholder="%s"/>
248+ <field name="l10n_mx_street3" placeholder="%s"/>
249+ <field name="l10n_mx_street4" placeholder="%s"/>
250+ <field name="street2" placeholder="%s"/>
251 <div class="address_format">
252 %s
253- <field name="state_id" class="oe_no_button" placeholder="State" style="width: 37%%" options='{"no_open": True}' on_change="onchange_state(state_id)"/>
254- <field name="zip" placeholder="ZIP" style="width: 20%%"/>
255+ <field name="state_id" class="oe_no_button" placeholder="%s" style="width: 37%%" options='{"no_open": True}' on_change="onchange_state(state_id)"/>
256+ <field name="zip" placeholder="%s" style="width: 20%%"/>
257 </div>
258- <field name="l10n_mx_city2" placeholder="Localidad"/>
259- <field name="country_id" placeholder="Country" class="oe_no_button" options='{"no_open": True}'/>
260+ <field name="l10n_mx_city2" placeholder="%s"/>
261+ <field name="country_id" placeholder="%s" class="oe_no_button" options='{"no_open": True}'/>
262 </div>
263 <field name="website" widget="url" placeholder="e.g. www.openerp.com"/>
264 </group>
265@@ -114,7 +119,7 @@
266 options='{"no_open": True}' attrs="{'invisible': [('is_company','=', True)]}" />
267 </group>
268 </group>
269- """ % (city)
270+ """ % (street, external, internal, street2, city, state, cp, locality, country)
271 }
272 for k, v in layouts.items():
273 if fmt and (k in fmt):
274@@ -134,7 +139,7 @@
275 view_id = self.pool.get('ir.model.data').get_object_reference(
276 cr, user, 'base', 'view_partner_simple_form')[1]
277 res = super(res_partner, self).fields_view_get(
278- cr, user, view_id, view_type, context, toolbar=toolbar, submenu=submenu)
279+ cr, SUPERUSER_ID, view_id, view_type, context, toolbar=toolbar, submenu=submenu)
280 if view_type == 'form':
281 fields_get = self.fields_get(cr, user, [
282 'l10n_mx_street3', 'l10n_mx_street4', 'l10n_mx_city2'], context)
283
284=== modified file 'l10n_mx_partner_address/res_company_view_inherit.xml'
285--- l10n_mx_partner_address/res_company_view_inherit.xml 2013-06-08 04:00:25 +0000
286+++ l10n_mx_partner_address/res_company_view_inherit.xml 2013-09-12 22:20:12 +0000
287@@ -4,18 +4,14 @@
288 <record model="ir.ui.view" id="res_company_inherit_form_view">
289 <field name="name">res.company.inherit.form.view</field>
290 <field name="model">res.company</field>
291- <field name="inherit_id" ref="base.view_company_form" />
292+ <field name="inherit_id" ref="base.view_company_form"/>
293 <field name="arch" type="xml">
294-
295- <xpath expr="//field[@name='street2']" position="after" >
296- <field name="l10n_mx_street4" placeholder="No. Exterior..."/>
297- <field name="l10n_mx_street3" placeholder="No. Interior..."/>
298- <field name="l10n_mx_city2" placeholder="Localidad"/>
299+ <xpath expr="//field[@name='street2']" position="after">
300+ <field name="l10n_mx_street3" placeholder="No. External..."/>
301+ <field name="l10n_mx_street4" placeholder="No. Internal..."/>
302+ <field name="l10n_mx_city2" placeholder="Locality"/>
303 </xpath>
304-
305 </field>
306 </record>
307-
308-
309 </data>
310 </openerp>