Merge lp:~vauxoo/addons-vauxoo/addons-vauxoo-61-mrp_request_return_cancel-dev-fernando into lp:addons-vauxoo/6.1
Proposed by
Fernando Lopez
Status: | Merged |
---|---|
Merged at revision: | 547 |
Proposed branch: | lp:~vauxoo/addons-vauxoo/addons-vauxoo-61-mrp_request_return_cancel-dev-fernando |
Merge into: | lp:addons-vauxoo/6.1 |
Diff against target: |
131 lines (+113/-0) 3 files modified
mrp_request_return_cancel/__init__.py (+26/-0) mrp_request_return_cancel/__openerp__.py (+40/-0) mrp_request_return_cancel/mrp.py (+47/-0) |
To merge this branch: | bzr merge lp:~vauxoo/addons-vauxoo/addons-vauxoo-61-mrp_request_return_cancel-dev-fernando |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Fernando Lopez (community) | Needs Resubmitting | ||
Moisés López - http://www.vauxoo.com | Pending | ||
Review via email: mp+131454@code.launchpad.net |
Description of the change
Este módulo cancela los picking generados por los request o return del módulo mrp_request_return al cancelar la orden de producción respectiva.
To post a comment you must log in.
Fer,
Cuando validas nulos, el unico que no validas es el id, ya que es un campo
requerido y siempre definido.
Es decir la validación
if line.id:
No tiene mucho sentido.
Al menos que el campo a leer sea un many2one.
Es decir,
if journal_id
valor = journal_id.id
o
valor = journal_id and journal_id.id or False
Me explico?
Julio, me ayudas con palabras definir en vivo a Fer
Correo escrito desde un dispositivo móvil. Disculpa las faltas de
ortografía y la brevedad del email.
"No imprimas este email al menos que sea muy necesario, la ecología es cosa
de todos"
Moisés López - Vauxoo - moylop260
El 25/10/2012 12:17, "Fernando Lopez" <email address hidden> escribió:
> Fernando Lopez has proposed merging www.vauxoo. com (moylop260) /code.launchpad .net/~vauxoo/ addons- vauxoo/ addons- vauxoo- 61-mrp_ request_ return_ cancel- dev-fernando/ +merge/ 131454 /code.launchpad .net/~vauxoo/ addons- vauxoo/ addons- vauxoo- 61-mrp_ request_ return_ cancel- dev-fernando/ +merge/ 131454 return_ cancel' return_ cancel/ __init_ _.py' return_ cancel/ __init_ _.py 1970-01-01 00:00:00 +0000 return_ cancel/ __init_ _.py 2012-10-25 17:16:20 +0000 ####### ####### ####### ####### ####### ####### ####### ####### ####### ###### www.vauxoo. com ####### ####### ####### ####### ####### ####### ####### ####### ####### ####### ####### ####### ####### ####### ####### ####### ####### ####### ####### ####### www.gnu. org/licenses/ ####### ####### ####### ####### ####### ####### ####### ####### ####### ####### return_ cancel/ __opene. ..
> lp:~vauxoo/addons-vauxoo/addons-vauxoo-61-mrp_request_return_cancel-dev-fernando
> into lp:addons-vauxoo/6.1.
>
> Requested reviews:
> Moisés López - http://
>
> For more details, see:
>
> https:/
>
> Este módulo cancela los picking generados por los request o return del
> módulo mrp_request_return al cancelar la orden de producción respectiva.
> --
>
> https:/
> You are requested to review the proposed merge of
> lp:~vauxoo/addons-vauxoo/addons-vauxoo-61-mrp_request_return_cancel-dev-fernando
> into lp:addons-vauxoo/6.1.
>
> === added directory 'mrp_request_
> === added file 'mrp_request_
> --- mrp_request_
> +++ mrp_request_
> @@ -0,0 +1,26 @@
> +# -*- coding: utf-8 -*-
>
> +######
> +# Module Writen to OpenERP, Open Source Management Solution
> +#
> +# Copyright (c) 2012 Vauxoo - http://
> +# All Rights Reserved.
> +# <email address hidden>
>
> +######
> +# Coded by: fernando L (<email address hidden>)
>
> +######
> +#
> +# This program is free software: you can redistribute it and/or modify
> +# it under the terms of the GNU Affero General Public License as
> +# published by the Free Software Foundation, either version 3 of the
> +# License, or (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU Affero General Public License for more details.
> +#
> +# You should have received a copy of the GNU Affero General Public
> License
> +# along with this program. If not, see <http://
> >.
> +#
>
> +######
> +import mrp
> \ No newline at end of file
>
> === added file 'mrp_request_