Code review comment for lp:~vauxoo/addons-vauxoo/7.0-addons-vauxoo-project_conf-dev-julio

Enterado gracias
El abr 10, 2014 10:09 AM, "Julio Serna-http://www.vauxoo.com" <
<email address hidden>> escribió:

> Moy,
> EL resultado de las pruebas te las puse en la descripción de la tarea.
>
>
> 2014-04-10 9:21 GMT-05:00 Moisés López - http://www.vauxoo.com <
> <email address hidden>>:
>
> > Julio,
> > La prueba que hiciste, cuando decia No Receive, pero tambien decia, Si My
> > Emails
> > En que resultó?
> > Pusiste el resultado de cada pruena en algun lado?
> > El abr 9, 2014 6:07 PM, "Julio Serna-http://www.vauxoo.com" <
> > <email address hidden>> escribió:
> >
> > > Julio Serna-http://www.vauxoo.com has proposed merging
> > > lp:~vauxoo/addons-vauxoo/7.0-addons-vauxoo-project_conf-dev-julio into
> > > lp:addons-vauxoo/7.0.
> > >
> > > Requested reviews:
> > > Moisés López - http://www.vauxoo.com (moylop260)
> > >
> > > For more details, see:
> > >
> > >
> >
> https://code.launchpad.net/~vauxoo/addons-vauxoo/7.0-addons-vauxoo-project_conf-dev-julio/+merge/215062
> > >
> > > get name of stage with read without sent context for dont use lang of
> > user
> > > --
> > >
> > >
> >
> https://code.launchpad.net/~vauxoo/addons-vauxoo/7.0-addons-vauxoo-project_conf-dev-julio/+merge/215062
> > > You are requested to review the proposed merge of
> > > lp:~vauxoo/addons-vauxoo/7.0-addons-vauxoo-project_conf-dev-julio into
> > > lp:addons-vauxoo/7.0.
> > >
> > > === modified file 'project_conf/model/project.py'
> > > --- project_conf/model/project.py 2013-09-12 20:26:13 +0000
> > > +++ project_conf/model/project.py 2014-04-09 23:06:52 +0000
> > > @@ -37,11 +37,12 @@
> > > Send mail automatically to change task to Backlog and to
> Testing
> > > Leader.
> > > '''
> > > context = context or {}
> > > -
> > > + #Dont send context to dont get language of user in read method
> > > if ids.get('stage_id'):
> > > - if ids['stage_id'][1] == 'Backlog':
> > > + type = self.pool.get('project.task.type').read(cr, uid,
> > > ids['stage_id'][0], ['name'])
> > > + if type.get('name', False) == 'Backlog':
> > >
> > > self.send_mail_task(cr,uid,ids,'template_send_email_task_new',context)
> > > - elif ids['stage_id'][1] == 'Testing Leader':
> > > + elif type.get('name', False) == 'Testing Leader':
> > >
> > > self.send_mail_task(cr,uid,ids,'template_send_email_task_end',context)
> > >
> > > def send_mail_task(self,cr,uid,ids,template,context=None):
> > >
> > >
> > >
> >
> > --
> >
> >
> https://code.launchpad.net/~vauxoo/addons-vauxoo/7.0-addons-vauxoo-project_conf-dev-julio/+merge/215062
> > You proposed
> > lp:~vauxoo/addons-vauxoo/7.0-addons-vauxoo-project_conf-dev-julio for
> > merging.
> >
>
>
>
> --
> Julio Serna
> Vauxoo
> http://www.vauxoo.com
>
>
> https://code.launchpad.net/~vauxoo/addons-vauxoo/7.0-addons-vauxoo-project_conf-dev-julio/+merge/215062
> You are reviewing the proposed merge of
> lp:~vauxoo/addons-vauxoo/7.0-addons-vauxoo-project_conf-dev-julio into
> lp:addons-vauxoo/7.0.
>