Code review comment for lp:~vauxoo/addons-vauxoo/7.0-add_project_followers_rule-dev-ernesto

Revision history for this message
Moisés López - http://www.vauxoo.com (moylop260) wrote :

    print '----------------##---------------------------'
    try:
        with mute_logger('openerp.osv.orm'):
            with mute_logger('openerp.addons.base.ir.ir_model'):
                self.write(cr, ref("res_user_demo_task_rule0"), ref("project_task_test_vauxoo"), {'name':'write task'})
    except except_orm:
        error = tools.ustr( traceback.format_exc() )
        log( error )

Cambialo por
    log( '----------------##---------------------------' )
    test_ok = False
    try:
        with mute_logger('openerp.osv.orm'):
            self.write(cr, ref("res_user_demo_task_rule0"), ref("project_task_test_vauxoo"), {'name':'write task'})
    except except_orm:
        test_ok = True
        error = tools.ustr( traceback.format_exc() )
        #log( error )
    assert test_ok, "Test failed."

Es decir, cambia los print's por log's y cambia los log de errores por assert's de banderas, por favor.

review: Needs Fixing

« Back to merge proposal