Code review comment for lp:~vauxoo/account-financial-report/7.0-report_webkit_afr-_data_dev-jorge

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Hi,

With the lines in <table><td>, you'll have problems with lines being cut or hidden between pages (that's a wkhtmltopdf bug, see comment #9 and #11 of https://code.google.com/p/wkhtmltopdf/issues/detail?id=566).

That's why we used solely <div> in our reports: we use "<div>" elements with the "display" css property (with values "table", "table-row", "table-cell", ...).

Example in our reports:
http://bazaar.launchpad.net/~account-report-core-editor/account-financial-report/7.0/view/head:/account_financial_report_webkit/report/templates/account_report_partners_ledger.mako#L26

And the css:
http://bazaar.launchpad.net/~account-report-core-editor/account-financial-report/7.0/view/head:/account_financial_report_webkit/data/financial_webkit_header.xml#L71

review: Needs Fixing

« Back to merge proposal