Code review comment for lp:~vauxoo/account-financial-report/7.0-report_webkit_afr-_data_dev-jorge

Revision history for this message
Frederic Clementi - Camptocamp (frederic-clementi) wrote :

Hello Vauxoo friends,

I will probably not make you happy but I must say that after my yesterday test of your financial reports module that I realized that the functional coverage is the same than the 'webkit_financial_report' module which is already in the community repository for some time and which has already received several contributions ('journal ledger' from Syleam, XLS export from Noviat, bug fixes...). So, it is a functional duplication that I will not approve this MP.

I would also like to add that the 'account_financial_reports_webkit' are mature for a long time, widely used in production and by other partners especially in Europe.

Even more mportant, I think 'account_financial_reports_webkit' goes further in terms of functionalities.
i.e :
* The Open Invoice report - which can list you open invoices (over several fy if necessary)
* All reports can be printed at any date in the past (thanks to the last_rec_date field). This feature is a MUST HAVE. I do not know if this is implemented on you side but without this financial reports are USELESS (because you cannot use the date on reconcile_id since you do not care of the date of the reconcile but you need the date of the last payment for example)
* Handling previous fiscal year initial balance on the fly calculation IF the opening entry is not generated
* Other modules like 'account_revaluation' provide other reports based on the same model with an extra granularity on currencies
* General ledger : you can centralize account (goup account move lines by period) in order to generate less pdf pages and increase perf.
* You can compare until 4 fy and/or periods with a total flexibility + you can see the diff in value and %
audit tools like the clearing date analysis (embedded in the open invoice reports)
...

On the other hand, this module still miss :
* P&L and B/S reports
* possibility to get a 12 months views
* possibility to customize your css (but we could add a mechanism to handle this quite easily we think)

@Nohmar : I have no doubt that you agree on principle but I guess you cannot switch so easily... so how can we proceed ?

Many thanks for your understanding

Frederic

« Back to merge proposal