Unity

Merge lp:~vanvugt/unity/fix-908004-trunk into lp:unity

  1. fix-908004-trunk
  2. Merge into trunk
Proposed by Daniel van Vugt
Status: Merged
Approved by: Sam Spilsbury
Approved revision: no longer in the source branch.
Merged at revision: 1848
Proposed branch: lp:~vanvugt/unity/fix-908004-trunk
Merge into: lp:unity
Diff against target: 15 lines (+2/-3)
1 file modified
plugins/unityshell/src/unityshell.cpp (+2/-3)
To merge this branch: bzr merge lp:~vanvugt/unity/fix-908004-trunk
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Review via email: mp+86781@code.launchpad.net

Description of the change

Log messages from unity should say "unity", not "glib" which is totally misleading (LP: #908004)

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'plugins/unityshell/src/unityshell.cpp'
--- plugins/unityshell/src/unityshell.cpp 2011-12-16 19:50:15 +0000
+++ plugins/unityshell/src/unityshell.cpp 2011-12-23 07:09:24 +0000
@@ -2673,9 +2673,8 @@
2673 const gchar* message,2673 const gchar* message,
2674 gpointer user_data)2674 gpointer user_data)
2675{2675{
2676 // Since we aren't entirely sure if log_domain contains anything, lets have2676 // If nothing else, all log messages from unity should be identified as such
2677 // a glib prefix.2677 std::string module("unity");
2678 std::string module("glib");
2679 if (log_domain)2678 if (log_domain)
2680 {2679 {
2681 module += std::string(".") + log_domain;2680 module += std::string(".") + log_domain;