Code review comment for lp:~vanvugt/unity/fix-865006

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Cool, looks good, you'll need to do 2 more things.

At any point where we call damageRegion () from within unity, you need to disable our handler so as to not get the "feedback effect" (such that we don't update damage on our own updates)

cScreen->damageRegionSetEnabled (this, false);
cScreen->damageRegion (reg);
cScreen->damageRegionSetEnabled (this, true);

Also bonus points for disabling damage region updates after UnityScreen::paintDisplay is called and re-enabling them just before ScreenEffectFramebufferObject::bind () is called.

« Back to merge proposal