Code review comment for lp:~vanvugt/unity/fix-865006
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
Sam, I've reviewed the damage logic through composite and opengl and I can't find any reason why glPaintOutput's region would ever exclude part of the output that has been damaged. Except for overlays, but we don't intend to draw blurs on top of overlays.
Please point me to the code that could cause glPaintOutput's region to be incomplete. I still don't see any reason for wrapping damage functions, which would be both uglier and less efficient.