Code review comment for lp:~vanvugt/unity/fix-1036095

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

> +#include <NuxGraphics/GestureEvent.h>
>
> Why have you added this line? Nux/View.h uses a forward declaration for it
> IIRC.

Whoops, approved the whole branch just before you added your comment. Put it back to needs review ... lets hope the automerger doesn't see it.

I think he's got this so that you'll immediately know if you're missing support for it, though it should probably go inside of the files that use it and not the header itself.

review: Needs Fixing

« Back to merge proposal