Code review comment for lp:~vanvugt/unity-mir/fix-1255045

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> Land this to fix bug by all means, but is it only the compositor that needs to
> be paused/resumed? Not the input and connector services too (via
> display->pause()/resume())?

OK can we clarify the intent?

Are we intentionally pausing and resuming the compositing service or are we only doing that as a way to run:

    for (auto& f : thread_functors)
        f->schedule_compositing();

If, as I suspect, the latter then Compositor probably ought to publish a schedule_compositing() function (ideally with a parameter specifying what area(s) need drawing).

In any case this notification (or the pause/resume cycle if that's really needed) probably ought to come from the Display::configure() implementation, not from unity-mir.

« Back to merge proposal