Code review comment for lp:~vanvugt/ubuntu/oneiric/xserver-xorg-input-synaptics/fix-754000

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

@Chase: I don't have access to a machine to test with right now, but do have new theories as to what I could try changing. In the mean time, could you please try:

1. Finding out if your touchpad is semi_mt, and if so, whether I should have an additional check in the style of:
is_inside_active_area(priv, ecpriv->min_x, ecpriv->min_y) &&
is_inside_active_area(priv, ecpriv->max_x, ecpriv->max_y)
???

2. Insert a log message in GrailCountFingers to discover the exact range of grail_contact values that grail is reporting for your hardware. When I did this on a Macbook Air 11", I found it was the same coordinate range 1280x800 as reported in Xorg.0.log. But obviously your hardware is a little different.

3. Change your Synaptics Area to 0 0 0 3059, so the bottom 50% is available to use as a button. I am suspicious that your current area size is too small to fit a finger on the Dell Inspiron touchpad. I know it seems to work in the current version, but there is a chance that is actually by side-effect of a bug. Not likely, but worth testing. :)

« Back to merge proposal