Code review comment for lp:~vanvugt/ubuntu/oneiric/xserver-xorg-input-synaptics/fix-754000

Revision history for this message
Chase Douglas (chasedouglas) wrote :

Here's what you requested:

props:
Device 'SynPS/2 Synaptics TouchPad':
 Device Enabled (135): 1
 Coordinate Transformation Matrix (137): 1.000000, 0.000000, 0.000000, 0.000000, 1.000000, 0.000000, 0.000000, 0.000000, 1.000000
 Device Accel Profile (252): 1
 Device Accel Constant Deceleration (253): 2.500000
 Device Accel Adaptive Deceleration (254): 1.000000
 Device Accel Velocity Scaling (255): 12.500000
 Synaptics Edges (256): 1760, 5302, 1639, 4479
 Synaptics Finger (257): 24, 29, 255
 Synaptics Tap Time (258): 180
 Synaptics Tap Move (259): 232
 Synaptics Tap Durations (260): 180, 180, 100
 Synaptics Tap FastTap (261): 0
 Synaptics Middle Button Timeout (262): 75
 Synaptics Two-Finger Pressure (263): 280
 Synaptics Two-Finger Width (264): 6
 Synaptics Scrolling Distance (265): 250, 250
 Synaptics Edge Scrolling (266): 0, 0, 0
 Synaptics Two-Finger Scrolling (267): 1, 1
 Synaptics Move Speed (268): 1.000000, 1.750000, 0.037893, 40.000000
 Synaptics Edge Motion Pressure (269): 29, 159
 Synaptics Edge Motion Speed (270): 1, 422
 Synaptics Edge Motion Always (271): 0
 Synaptics Off (272): 1
 Synaptics Locked Drags (273): 0
 Synaptics Locked Drags Timeout (274): 5000
 Synaptics Tap Action (275): 2, 3, 0, 0, 1, 3, 2
 Synaptics Click Action (276): 1, 1, 1
 Synaptics Circular Scrolling (277): 0
 Synaptics Circular Scrolling Distance (278): 0.100000
 Synaptics Circular Scrolling Trigger (279): 0
 Synaptics Circular Pad (280): 0
 Synaptics Palm Detection (281): 0
 Synaptics Palm Dimensions (282): 9, 199
 Synaptics Coasting Speed (283): 20.000000, 50.000000
 Synaptics Pressure Motion (284): 29, 159
 Synaptics Pressure Motion Factor (285): 1.000000, 1.000000
 Synaptics Grab Event Device (286): 0
 Synaptics Gestures (287): 1
 Synaptics Capabilities (288): 1, 0, 1, 1, 1, 1, 1
 Synaptics Pad Resolution (289): 121, 58
 Synaptics Area (290): 0, 0, 0, 4100
 Synaptics Jumpy Cursor Threshold (291): 90

grep range /var/log/Xorg.0.log:
[ 83.896] (--) SynPS/2 Synaptics TouchPad: x-axis range 1472 - 5590
[ 83.896] (--) SynPS/2 Synaptics TouchPad: y-axis range 1408 - 4710
[ 83.896] (--) SynPS/2 Synaptics TouchPad: pressure range 0 - 255
[ 83.896] (--) SynPS/2 Synaptics TouchPad: finger width range 0 - 15
[ 21001.277] (--) cndougla’s trackpad: x-axis range -2909 - 3167
[ 21001.278] (--) cndougla’s trackpad: y-axis range -2456 - 2565
[ 21001.278] (--) cndougla’s trackpad: invalid pressure range. defaulting to 0 - 256
[ 21001.278] (--) cndougla’s trackpad: invalid finger width range. defaulting to 0 - 16

From /usr/share/X11/xorg.conf.d/51-synaptics-quirks.conf:
Section "InputClass"
        Identifier "Dell Inspiron embedded buttons quirks"
        MatchTag "inspiron_1011|inspiron_1012"
        MatchDevicePath "/dev/input/event*"
        Driver "synaptics"
        Option "JumpyCursorThreshold" "90"
        Option "AreaBottomEdge" "4100"
EndSection

I'm not sure what the correct conversion is off the top of my head.

I also tested two-handed dragging before and after your changes. It works correctly right now, and it stops working after installing your changes.

« Back to merge proposal