Code review comment for lp:~vanvugt/ubuntu/oneiric/xserver-xorg-input-synaptics/fix-754000

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I have double-checked and can't reproduce the bug Chase describes (any more). Certainly the bug existed in rev 38, but it is fixed in the latest revision 40.

Please test the build of revision 40 (vv2) in my PPA:
https://launchpad.net/~vanvugt/+archive/unity/+packages
(version 1.3.99+git20110116.0e27ce3a-0ubuntu12vv2)

I have tested masking out the bottom quarter of my 1280x800 clickpad using:
  xinput set-prop bcm5974 "Synaptics Area" 0 0 0 600
And then I can do the two-handed text selection you describe (although it sporadically fails to sense the touch at all, which appears to be an unrelated bug).

As an added bonus, the fix in revision 40 also appears to fix bug 798047 :)

When I add debug output I see grail is outputting device coordinates. And these appear to be exactly the same coordinates required by is_inside_active_area. So it does not appear I have made any coordinate conversion mistakes.

Could some one else please test the fix using the debs in the above PPA?

« Back to merge proposal