Merge ~vanvugt/ubuntu/+source/gnome-shell:fix-eoan-purple-system-background into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/master

Proposed by Daniel van Vugt
Status: Merged
Merged at revision: ab6dad7455a89f51b098aa76b0ea01487aff00ee
Proposed branch: ~vanvugt/ubuntu/+source/gnome-shell:fix-eoan-purple-system-background
Merge into: ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/master
Diff against target: 73 lines (+17/-27)
1 file modified
debian/patches/ubuntu/background_login.patch (+17/-27)
Reviewer Review Type Date Requested Status
Iain Lane Approve
Didier Roche-Tolomelli Pending
Review via email: mp+372051@code.launchpad.net

Commit message

background_login.patch: Match 19.10 Yaru purple login screen with noise.

This way the login animation will appear to expand over the login screen
(system background) instead of suddenly replacing it.

Description of the change

It would be so nice to automate matching of these two styles, but nobody has made the time yet.

P.S. The diff of the diff looks wrong but it's not. Try just reviewing the whole file:
https://git.launchpad.net/~vanvugt/ubuntu/+source/gnome-shell/tree/debian/patches/ubuntu/background_login.patch?h=fix-eoan-purple-system-background

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote :

thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/patches/ubuntu/background_login.patch b/debian/patches/ubuntu/background_login.patch
index 98334d7..29bbceb 100644
--- a/debian/patches/ubuntu/background_login.patch
+++ b/debian/patches/ubuntu/background_login.patch
@@ -1,27 +1,15 @@
1From: Daniel van Vugt <daniel.van.vugt@canonical.com>1Description: js/ui/background.js: Match 19.10 Yaru purple login screen with noise.
2Date: Wed, 6 Mar 2019 14:48:10 +00002 This way the login animation will appear to expand over the login
3Subject: js/ui/background.js: Use Ubuntu purple to match login screen3 screen (system background) instead of suddenly replacing it.
4
5Original author: Didier Roche <didrocks@ubuntu.com>
6Bug-Ubuntu: https://launchpad.net/bugs/1813119
7Last-Update: 2019-03-01
8Forwarded: not-needed
9
10This way the login animation will appear to expand over the login
11screen (system background) instead of suddenly replacing it.
12Original author: Didier Roche <didrocks@ubuntu.com>4Original author: Didier Roche <didrocks@ubuntu.com>
13Author: Daniel van Vugt <daniel.van.vugt@canonical.com>5Author: Daniel van Vugt <daniel.van.vugt@canonical.com>
14Bug-Ubuntu: https://launchpad.net/bugs/18131196Last-Update: 2019-08-30
15Last-Update: 2019-03-01
16Forwarded: not-needed7Forwarded: not-needed
17---
18 js/ui/background.js | 20 ++++++++++++++++++++
19 1 file changed, 20 insertions(+)
208
21diff --git a/js/ui/background.js b/js/ui/background.js9Index: gnome-shell/js/ui/background.js
22index babc1e4..ab1dba0 10064410===================================================================
23--- a/js/ui/background.js11--- gnome-shell.orig/js/ui/background.js
24+++ b/js/ui/background.js12+++ gnome-shell/js/ui/background.js
25@@ -96,6 +96,7 @@13@@ -96,6 +96,7 @@
26 const { Clutter, GDesktopEnums, Gio, GLib, GnomeDesktop, Meta } = imports.gi;14 const { Clutter, GDesktopEnums, Gio, GLib, GnomeDesktop, Meta } = imports.gi;
27 const Signals = imports.signals;15 const Signals = imports.signals;
@@ -30,16 +18,18 @@ index babc1e4..ab1dba0 100644
30 const LoginManager = imports.misc.loginManager;18 const LoginManager = imports.misc.loginManager;
31 const Main = imports.ui.main;19 const Main = imports.ui.main;
32 const Params = imports.misc.params;20 const Params = imports.misc.params;
33@@ -499,6 +500,25 @@ let _systemBackground;21@@ -501,6 +502,27 @@ var SystemBackground = class SystemBackg
34
35 var SystemBackground = class SystemBackground {
36 constructor() {22 constructor() {
23 let file = Gio.File.new_for_uri('resource:///org/gnome/shell/theme/noise-texture.png');
24
37+ // Yaru is default ubuntu theme, match GDM look25+ // Yaru is default ubuntu theme, match GDM look
38+ if (Desktop.is("ubuntu")) {26+ if (Desktop.is("ubuntu")) {
39+ if (_systemBackground == null) {27+ if (_systemBackground == null) {
40+ _systemBackground = new Meta.Background({ meta_display: global.display });28+ _systemBackground = new Meta.Background({ meta_display: global.display })
41+ let [, ubuntuColor] = Clutter.Color.from_string('#2C001E');29+ // Yaru uses darken(#762572, 10%) + noise for #lockDialogGroup
30+ let [, ubuntuColor] = Clutter.Color.from_string('#4f194c');
42+ _systemBackground.set_color(ubuntuColor);31+ _systemBackground.set_color(ubuntuColor);
32+ _systemBackground.set_file(file, GDesktopEnums.BackgroundStyle.WALLPAPER);
43+ }33+ }
44+ this.actor = new Meta.BackgroundActor({ meta_display: global.display,34+ this.actor = new Meta.BackgroundActor({ meta_display: global.display,
45+ monitor: 0,35+ monitor: 0,
@@ -53,6 +43,6 @@ index babc1e4..ab1dba0 100644
53+ return;43+ return;
54+ }44+ }
55+45+
56 let file = Gio.File.new_for_uri('resource:///org/gnome/shell/theme/noise-texture.png');
57
58 if (_systemBackground == null) {46 if (_systemBackground == null) {
47 _systemBackground = new Meta.Background({ meta_display: global.display });
48 _systemBackground.set_color(DEFAULT_BACKGROUND_COLOR);

Subscribers

People subscribed via source and target branches