Merge lp:~vanvugt/qtmir/fix-1495871 into lp:qtmir
Proposed by
Daniel van Vugt
Status: | Rejected |
---|---|
Rejected by: | Daniel d'Andrada |
Proposed branch: | lp:~vanvugt/qtmir/fix-1495871 |
Merge into: | lp:qtmir |
Diff against target: |
33 lines (+9/-7) 1 file modified
src/modules/Unity/Application/mirsurfaceitem.cpp (+9/-7) |
To merge this branch: | bzr merge lp:~vanvugt/qtmir/fix-1495871 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel d'Andrada (community) | Disapprove | ||
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Review via email:
|
Commit message
Fix fd leak (actually a whole texture+buffer leak) of zombie surfaces
(LP: #1495871)
Description of the change
I'm not completely confident about this. It seems to work, but the fds in question still come and go under normal usage anyway. So the "leak" is hard to detect reliably.
Added to that; every attempt I try to detect GL errors, I see none. But there are other plausible explanations for that...
Then again, if this branch really is working, it might be working for reasons other than those in the comments :)
To post a comment you must log in.
Unmerged revisions
- 378. By Daniel van Vugt
-
Fix fd leak (actually a whole texture leak) of zombie surfaces
(LP: #1495871)I think. Fingers crossed.
FAILED: Continuous integration, rev:378 jenkins. qa.ubuntu. com/job/ qtmir-ci/ 438/ jenkins. qa.ubuntu. com/job/ qtmir-vivid- amd64-ci/ 134/console jenkins. qa.ubuntu. com/job/ qtmir-vivid- armhf-ci/ 134/console jenkins. qa.ubuntu. com/job/ qtmir-vivid- i386-ci/ 16/console jenkins. qa.ubuntu. com/job/ qtmir-wily- amd64-ci/ 171 jenkins. qa.ubuntu. com/job/ qtmir-wily- armhf-ci/ 171 jenkins. qa.ubuntu. com/job/ qtmir-wily- armhf-ci/ 171/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ qtmir-wily- i386-ci/ 16
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/qtmir- ci/438/ rebuild
http://