Nux

Code review comment for lp:~vanvugt/nux/fix-769957-natty

Revision history for this message
Jay Taoko (jaytaoko) wrote :

I was able to reproduce the problem and confirm that XFlush will destroy the remaining windows. Here is a sample output without XFlush (after loading/unloading several plugins):

jay@jay-linux:~$ for i in `xwininfo -root -children | awk '/^ *0x/ {print $1}'`; do xwininfo -id $i -all | grep '"panel"'; done
        0x7800003 "panel": () 1600x24+0+0 +0+0
        0x7600003 "panel": () 1600x24+0+0 +0+0
        0x7400003 "panel": () 1600x24+0+0 +0+0
        0x7200003 "panel": () 1600x24+0+0 +0+0
        0x7000003 "panel": () 1600x24+0+0 +0+0
        0x6e00003 "panel": () 1600x24+0+0 +0+0
        0x6a00003 "panel": () 1600x24+0+0 +0+0
        0x6800003 "panel": () 1600x24+0+0 +0+0
        0x6200003 "panel": () 1600x24+0+0 +0+0

I also confirm that the drop shadows of the Panel and Launcher becomes darker.

However I couldn't test your branch right away because I was getting crashes when loading/unloading plugins (i was running Nux in debug mode: add "--enable-debug" to nux autogen command line). I have fixed the issues in both Unity and Nux:
    http://bazaar.launchpad.net/~unity-team/nux/0.9/revision/350
    https://code.launchpad.net/~unity-team/unity/unity-sru-fix-mem-leaks/+merge/62927

Your branch is approved.

review: Approve

« Back to merge proposal