Mir

Code review comment for lp:~vanvugt/mir/wait-result

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

I don't see anything in the recent discussion that relates to the pointlessness of being able to wait for a boolean result that tells the client nothing useful. In fact, I see little point in being able to wait on these requests to the server.

> The last case is the curious one. So I'm saying if result == true then the shell has successfully
> set exactly what you asked for.

But even if we were to make a guarantee that the corresponding state change event has been processed by the client before the wait completes with true there can be no guarantee that the state hasn't changed again.

So whether the result is true or false the boolean tells nothing about the current state.

review: Disapprove

« Back to merge proposal