Mir

Code review comment for lp:~vanvugt/mir/unocclude

Revision history for this message
Andreas Pokorny (andreas-pokorny) wrote :

> I think you're planning for the wrong approach. The renderer should never feed
> back directly to the client as it's just a /view/. The renderer shall never
> communicate with clients in any way. Instead we should indirectly observe that
> a client's become occluded. This is easy using BufferConsumingFunctor which
> observes physical frame completion - if and when lp:~vanvugt/mir/judder lands.

Hmm where did somebody indicate that the renderer should feed back to the clients?

> Occlusion detection is designed to block clients that are not visible. That's
> it's purpose. If we're serious about making things non-blocking then it makes
> no sense to keep it as it only gets in the way (as mentioned here:
> https://code.launchpad.net/~vanvugt/mir/judder/+merge/216694)

It also helps avoid unnecessary overdraw.

review: Needs Fixing

« Back to merge proposal