Code review comment for lp:~vanvugt/mir/test-pkgconfig

50 +set(LIBDIR ${Mir_BINARY_DIR}/lib)
51 +set(INCLUDEDIR ${Mir_SOURCE_DIR}/include/client)
52 +set(COMMON_INCLUDEDIR ${Mir_SOURCE_DIR}/include/shared)
53 +configure_file(${Mir_SOURCE_DIR}/src/client/mirclient.pc.in
54 + ${StandaloneClient_BINARY_DIR}/mirclient.pc)
55 +set(ENV{PKG_CONFIG_PATH} ${StandaloneClient_BINARY_DIR})

This is the code that is tested. Not the code in ${Mir_SOURCE_DIR}/src/client/CMakeLists.txt that generates the real mirclient.pc. Similarly the mirserver.pc code.

I'm not sure what the right way to test is, but cut, paste & edit of the code setting these variables before configure_file() isn't enough.