Mir

Merge lp:~vanvugt/mir/test-1415321 into lp:mir

Proposed by Daniel van Vugt
Status: Merged
Approved by: Alan Griffiths
Approved revision: no longer in the source branch.
Merged at revision: 2275
Proposed branch: lp:~vanvugt/mir/test-1415321
Merge into: lp:mir
Diff against target: 24 lines (+17/-0)
1 file modified
examples/CMakeLists.txt (+17/-0)
To merge this branch: bzr merge lp:~vanvugt/mir/test-1415321
Reviewer Review Type Date Requested Status
Alan Griffiths Approve
Alexandros Frantzis (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+247796@code.launchpad.net

Commit message

Introduce ABI regression tests for LP: #1415321.
Still disabled till the bug is fixed.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

I'd rather see a test that I can run being added than a comment about it. (Even if the test needs to be enabled manually.)

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

Looks good.

review: Approve
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'examples/CMakeLists.txt'
--- examples/CMakeLists.txt 2015-01-19 06:55:41 +0000
+++ examples/CMakeLists.txt 2015-01-29 05:20:49 +0000
@@ -171,3 +171,20 @@
171 mirserver171 mirserver
172 mircommon172 mircommon
173)173)
174
175# FIXME: Bug not fixed yet.
176if (MIR_ENABLE_TESTS AND MIR_TEST_CLIENT_ABI)
177 # Regression tests for LP: #1415321
178
179 # To see reasons for failure: ctest -V -R Clients-only-use-client-symbols
180 add_test(NAME Clients-only-use-client-symbols
181 WORKING_DIRECTORY ${CMAKE_BINARY_DIR}/bin
182 COMMAND /bin/sh -c "!(nm -u .mir_demo_client_* mir_demo_client* | grep -v @@MIR_CLIENT | grep 'U mir_')"
183 )
184
185 # To see reasons for failure: ctest -V -R Clients-only-use-client-ABI
186 add_test(NAME Clients-only-use-client-ABI
187 WORKING_DIRECTORY ${CMAKE_BINARY_DIR}/bin
188 COMMAND /bin/sh -c "!(objdump -p .mir_demo_client_* mir_demo_client* | grep NEEDED | grep libmir | grep -v libmirclient)"
189 )
190endif ()

Subscribers

People subscribed via source and target branches