Mir

Merge lp:~vanvugt/mir/test-1415321 into lp:mir

  1. test-1415321
  2. Merge into development-branch
Proposed by Daniel van Vugt
Status: Merged
Approved by: Alan Griffiths
Approved revision: no longer in the source branch.
Merged at revision: 2275
Proposed branch: lp:~vanvugt/mir/test-1415321
Merge into: lp:mir
Diff against target: 24 lines (+17/-0)
1 file modified
examples/CMakeLists.txt (+17/-0)
To merge this branch: bzr merge lp:~vanvugt/mir/test-1415321
Reviewer Review Type Date Requested Status
Alan Griffiths Approve
Alexandros Frantzis (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+247796@code.launchpad.net

Commit message

Introduce ABI regression tests for LP: #1415321.
Still disabled till the bug is fixed.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:2270
http://jenkins.qa.ubuntu.com/job/mir-ci/2843/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/1107
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/1106
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/1068
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-vivid-amd64-ci/840
        deb: http://jenkins.qa.ubuntu.com/job/mir-vivid-amd64-ci/840/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/1068
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/1068/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/4124
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17543

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/2843/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

I'd rather see a test that I can run being added than a comment about it. (Even if the test needs to be enabled manually.)

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:2272
http://jenkins.qa.ubuntu.com/job/mir-ci/2850/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/1119
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/1118
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/1080
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-vivid-amd64-ci/847
        deb: http://jenkins.qa.ubuntu.com/job/mir-vivid-amd64-ci/847/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/1080
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/1080/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/4134
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17593

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/2850/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

Looks good.

review: Approve
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'examples/CMakeLists.txt'
2--- examples/CMakeLists.txt 2015-01-19 06:55:41 +0000
3+++ examples/CMakeLists.txt 2015-01-29 05:20:49 +0000
4@@ -171,3 +171,20 @@
5 mirserver
6 mircommon
7 )
8+
9+# FIXME: Bug not fixed yet.
10+if (MIR_ENABLE_TESTS AND MIR_TEST_CLIENT_ABI)
11+ # Regression tests for LP: #1415321
12+
13+ # To see reasons for failure: ctest -V -R Clients-only-use-client-symbols
14+ add_test(NAME Clients-only-use-client-symbols
15+ WORKING_DIRECTORY ${CMAKE_BINARY_DIR}/bin
16+ COMMAND /bin/sh -c "!(nm -u .mir_demo_client_* mir_demo_client* | grep -v @@MIR_CLIENT | grep 'U mir_')"
17+ )
18+
19+ # To see reasons for failure: ctest -V -R Clients-only-use-client-ABI
20+ add_test(NAME Clients-only-use-client-ABI
21+ WORKING_DIRECTORY ${CMAKE_BINARY_DIR}/bin
22+ COMMAND /bin/sh -c "!(objdump -p .mir_demo_client_* mir_demo_client* | grep NEEDED | grep libmir | grep -v libmirclient)"
23+ )
24+endif ()

Subscribers

People subscribed via source and target branches