Mir

Code review comment for lp:~vanvugt/mir/swap-then-flip

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Mostly good. But surely:

456 - void post_update() override
457 + void gl_swap_buffers() override
458 + {
459 + increment_post_count();
460 + }
461 +
462 + void flip() override
463 {
464 increment_post_count();
465 }

"post_count" is now a misnomer and also is incremented by two calls where it would have been incremented once before.

review: Needs Fixing

« Back to merge proposal