Mir

Code review comment for lp:~vanvugt/mir/surface-types

Revision history for this message
Robert Carr (robertcarr) wrote :

>> 305:
Whitespace

>> 821:

This would be more in line with the rest of the code style if there were a few tests:

TEST_F(ShellSurface, default_surface_type_is_normal)
TEST_F(ShellSurface, takes_surface_type_from_configure)
TEST_F(ShellSurface, invalid_surface_type_throw_behavior)

This would improve the failure output significantly I think

review: Needs Fixing

« Back to merge proposal